Skip to content

benchmark: add variety of inputs to text-encoder - #45787

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
anonrig:benchmark/text-encoder-into
Dec 10, 2022
Merged

benchmark: add variety of inputs to text-encoder#45787
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
anonrig:benchmark/text-encoder-into

Conversation

@anonrig

@anonriganonrig commented Dec 8, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This pull request is taking from my previous pull request, and updates the text-encoder types to include ascii, latin and utf8 characters to have a much more broad benchmarking for text-encoder.

Referencing #45701

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Dec 8, 2022
@anonriganonrig added performance Issues and PRs related to the performance of Node.js. request-ci Add this label to start a Jenkins CI on a PR. util Issues and PRs related to the built-in util module. benchmark Issues and PRs related to the benchmark subsystem. and removed util Issues and PRs related to the built-in util module. benchmark Issues and PRs related to the benchmark subsystem. labels Dec 8, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48347/

addaleax
addaleax approved these changes Dec 8, 2022
View reviewed changes
Comment threadbenchmark/util/text-encoder.js Outdated
@anonriganonrig added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 8, 2022
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48350/

@nodejs-github-bot

nodejs-github-bot commented Dec 8, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48355/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 8, 2022
@github-actionsgithub-actionsBot mentioned this pull request Dec 9, 2022
Open
5 tasks
@github-actionsgithub-actionsBot mentioned this pull request Dec 10, 2022
Open
9 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2022
@nodejs-github-bot
nodejs-github-bot merged commit b06fd8c into nodejs:mainDec 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

Landed in b06fd8c

This was referenced Dec 11, 2022
Open
Open
targos pushed a commit that referenced this pull request Dec 12, 2022
@anonrig@targos
benchmark: add variety of inputs to text-encoder
25027fb
PR-URL: #45787
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@targostargos mentioned this pull request Dec 12, 2022
Merged
@github-actionsgithub-actionsBot mentioned this pull request Dec 13, 2022
Open
13 tasks
targos pushed a commit that referenced this pull request Dec 13, 2022
@anonrig@targos
benchmark: add variety of inputs to text-encoder
382efdf
PR-URL: #45787
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig@danielleadams
benchmark: add variety of inputs to text-encoder
7895f56
PR-URL: #45787
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@anonrig@danielleadams
benchmark: add variety of inputs to text-encoder
9925d20
PR-URL: #45787
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@anonrig@danielleadams
benchmark: add variety of inputs to text-encoder
d9dbaa2
PR-URL: #45787
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@daeyeondaeyeondaeyeon approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.performanceIssues and PRs related to the performance of Node.js.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig@nodejs-github-bot@addaleax@lpinca@daeyeon