Skip to content

doc: buffer.fill empty value - #45794

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
marco-ippolito:doc/buffer-fill-empty
Dec 12, 2022
Merged

doc: buffer.fill empty value#45794
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
marco-ippolito:doc/buffer-fill-empty

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Dec 9, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Resolves: #45727
The doc is missing the case where the Buffer.fill value is empty.
I've created a test (not sure if necessary) and added the behaviour to the doc

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 9, 2022
@marco-ippolitomarco-ippolito changed the title doc: Buffer.fill empty valuedoc: buffer.fill empty valueDec 9, 2022
mscdex
mscdex reviewed Dec 9, 2022
View reviewed changes
Comment threaddoc/api/buffer.md Outdated
@marco-ippolito@mscdex
doc: missing period
ca25dd3
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48379/

ShogunPanda
ShogunPanda approved these changes Dec 12, 2022
View reviewed changes

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

And no, there are never enough tests.

@ShogunPandaShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 12, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2022
@nodejs-github-bot
nodejs-github-bot merged commit c6c3eea into nodejs:mainDec 12, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 12, 2022

Copy link
Copy Markdown
Collaborator

Landed in c6c3eea

targos pushed a commit that referenced this pull request Dec 12, 2022
@marco-ippolito@targos
doc: buffer.fill empty value
bb16e9f
PR-URL: #45794Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@targostargos mentioned this pull request Dec 12, 2022
Merged
targos pushed a commit that referenced this pull request Dec 13, 2022
@marco-ippolito@targos
doc: buffer.fill empty value
8a90f5c
PR-URL: #45794Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@marco-ippolito@danielleadams
doc: buffer.fill empty value
a1b25c0
PR-URL: #45794Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@marco-ippolito@danielleadams
doc: buffer.fill empty value
108220c
PR-URL: #45794Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@marco-ippolito@danielleadams
doc: buffer.fill empty value
d0513f2
PR-URL: #45794Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@anonriganonriganonrig approved these changes
+1 more reviewer
@mscdexmscdexmscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The behavior of Buffer’s methods with an empty fill has not been documented.

5 participants

@marco-ippolito@nodejs-github-bot@mscdex@ShogunPanda@anonrig