Uh oh!
There was an error while loading. Please reload this page.
Fix DNS lookup on Android - #4580
Closed
daguej wants to merge 1 commit into
Closed
Conversation
`V4MAPPED` isn't supported by Android either (as of 6.0)
jasnell
commented
Jan 8, 2016
Member
LGTM but a test case would likely be helpful also (we do not currently run CI on Android, of course, but it would be handy to have). |
jasnell
commented
Jan 8, 2016
Member
cjihrig
commented
Jan 8, 2016
Contributor
@daguej what is the value of |
daguej
commented
Jan 8, 2016
ContributorAuthor
@cjihrig It's |
cjihrig
commented
Jan 8, 2016
Contributor
Ah, thanks. I was hoping it was |
cjihrig
commented
Jan 8, 2016
Contributor
LGTM. We might want to consider removing the implicit use of |
mscdex
commented
Jan 8, 2016
Contributor
LGTM |
jasnell pushed a commit
that referenced
this pull request
Jan 8, 2016
`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: #4580 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
commented
Jan 8, 2016
Member
Landed in c64018e |
daguej
commented
Jan 9, 2016
ContributorAuthor
Thanks -- close #3771? |
cjihrig
commented
Jan 9, 2016
Contributor
Thanks. Closed it. |
MylesBorins pushed a commit
that referenced
this pull request
Jan 11, 2016
`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: #4580 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jan 12, 2016
`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: #4580 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 28, 2016
`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: #4580 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 11, 2016
`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: #4580 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: nodejs#4580 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: nodejs#4580 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg
commented
Mar 22, 2016
Member
I'm seeking some feedback about how Node.js is used on Android if anyone watching this thread would like to tell us about it: nodejs/build#359 |
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
`V4MAPPED` isn't supported by Android either (as of 6.0) PR-URL: nodejs#4580 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V4MAPPEDisn't supported by Android either (as of 6.0).Fixes#3771.