Skip to content

test: order list alphabetically in test-bootstrap-modules - #45808

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:alphabetaic-order
Dec 11, 2022
Merged

test: order list alphabetically in test-bootstrap-modules#45808
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:alphabetaic-order

Conversation

@aduh95

@aduh95aduh95 commented Dec 10, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 10, 2022
@aduh95aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 10, 2022
@github-actions

github-actionsBot commented Dec 10, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48386/

@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48400/

@github-actionsgithub-actionsBot mentioned this pull request Dec 11, 2022
Open
11 tasks
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48407/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 7f9e4fa into nodejs:mainDec 11, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2022

Copy link
Copy Markdown
Collaborator

Landed in 7f9e4fa

@github-actionsgithub-actionsBot mentioned this pull request Dec 12, 2022
Open
11 tasks
targos pushed a commit that referenced this pull request Dec 12, 2022
@aduh95@targos
test: order list alphabetically in test-bootstrap-modules
703d4ef
PR-URL: #45808
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Dec 12, 2022
Merged
@github-actionsgithub-actionsBot mentioned this pull request Dec 13, 2022
Open
13 tasks
targos pushed a commit that referenced this pull request Dec 13, 2022
@aduh95@targos
test: order list alphabetically in test-bootstrap-modules
924f6ab
PR-URL: #45808
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Dec 14, 2022
Open
Open
@danielleadams

danielleadams commented Dec 30, 2022

Copy link
Copy Markdown
Contributor

Backport blocked by #45659

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@daeyeondaeyeondaeyeon approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@danielleadams@lpinca@richardlau@daeyeon