Uh oh!
There was an error while loading. Please reload this page.
test: change WPT status files into CommonJS files - #45826
Closed
panva wants to merge 2 commits into
Closed
Conversation
panva
commented
Dec 12, 2022
MemberAuthor
I've also considered yaml or json5 but felt CJS is more at home here and the present js linter can maintain the status files better. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
13 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
panva
commented
Dec 13, 2022
MemberAuthor
I will deal with merge conflicts when landing this. |
This was referenced Dec 14, 2022
13 tasks
panvaforce-pushed
the
wpt-update-status-files
branch
from
December 20, 2022 13:46
f9de90d to
39c0f19Comparepanva
commented
Dec 20, 2022
MemberAuthor
cc @nodejs/testing |
This comment was marked as outdated.
This comment was marked as outdated.
12 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
14 tasks
Uh oh!
There was an error while loading. Please reload this page.
panvaforce-pushed
the
wpt-update-status-files
branch
from
December 23, 2022 10:02
39c0f19 to
414ba16Compare
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Dec 23, 2022
Collaborator
This was referenced Dec 24, 2022
This was referenced Dec 31, 2022
joyeecheung
approved these changes
Jan 9, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
panvaforce-pushed
the
wpt-update-status-files
branch
from
February 13, 2023 08:57
414ba16 to
98de155Comparepanva
commented
Feb 16, 2023
MemberAuthor
actually, not going to bother atm with ideas around the WPTRunner still in flight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the WPT status files to be
.jsfiles.The motivation for this change is to be able to use the javascript syntax to minimize the likelyhood of conflicts when adding/removing expectations and to allow for comments to be added for test blocks that may be failing for a specificic reason.
This would also allow to make more failures optional depending on config rather than current workaround being flaky, e.g. the
consoleexpectations file could be:The linter is configured to support that (newline for every array element, newline for array brackets).
max-lenis disabled because we cannot control the length of WPT test names and want them to fit on a single line.