Skip to content

doc: remove release cleanup step - #45858

Merged
nodejs-github-bot merged 1 commit into
mainfrom
targos-patch-1
Dec 16, 2022
Merged

doc: remove release cleanup step#45858
nodejs-github-bot merged 1 commit into
mainfrom
targos-patch-1

Conversation

@targos

Copy link
Copy Markdown
Member
  • The pull request is automatically closed.
  • The branch is automatically deleted.

- The pull request is automatically closed.
- The branch is automatically deleted.
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 14, 2022

@RafaelGSSRafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aduh95

Copy link
Copy Markdown
Contributor
  • The pull request is automatically closed.
  • The branch is automatically deleted.

Is that true even for security releases?

bnb
bnb approved these changes Dec 14, 2022
@RafaelGSS

Copy link
Copy Markdown
Member
  • The pull request is automatically closed.
  • The branch is automatically deleted.

Is that true even for security releases?

The Pull Request is automatically closed, but the branch isn't deleted. I'm enabling it right now:

image

So I think we are good.

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@nodejs-github-bot
nodejs-github-bot merged commit a47939c into mainDec 16, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a47939c

@nodejs-github-bot
nodejs-github-bot deleted the targos-patch-1 branch December 16, 2022 14:14
targos added a commit that referenced this pull request Jan 1, 2023
- The pull request is automatically closed.
- The branch is automatically deleted.
PR-URL: #45858
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jan 2, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
- The pull request is automatically closed.
- The branch is automatically deleted.
PR-URL: #45858
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarboljuanarbol mentioned this pull request Jan 28, 2023
nodejs-github-bot pushed a commit that referenced this pull request Oct 20, 2023
The table of contents for the release process still references a
deleted section. Remove that reference, and renumber the following
table of contents entries so that they link through to the correct
sections.
PR-URL: #50216
Refs: #45858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Oct 23, 2023
The table of contents for the release process still references a
deleted section. Remove that reference, and renumber the following
table of contents entries so that they link through to the correct
sections.
PR-URL: #50216
Refs: #45858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
The table of contents for the release process still references a
deleted section. Remove that reference, and renumber the following
table of contents entries so that they link through to the correct
sections.
PR-URL: #50216
Refs: #45858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@targos@nodejs-github-bot@aduh95@RafaelGSS@bnb@lpinca@richardlau