Skip to content

document server.listen return val - #4590

Closed
Sequoia wants to merge 1 commit into
nodejs:masterfrom
Sequoia:document-server-listen-return-val
Closed

document server.listen return val#4590
Sequoia wants to merge 1 commit into
nodejs:masterfrom
Sequoia:document-server-listen-return-val

Conversation

@Sequoia

@SequoiaSequoia commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

closes#4571

@Sequoia

Sequoia commented Jan 8, 2016

Copy link
Copy Markdown
ContributorAuthor

Incidentally, do all the server methods return this for chaining? Would be worth noting if so. I can create PR to doc this if someone can confirm; else I can look into it at some point.

@jasnell

jasnell commented Jan 8, 2016

Copy link
Copy Markdown
Member

LGTM
@Sequoia ... one quick nit: the commit message should be updated to conform to our style guidelines. See: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit :-)

@jasnelljasnell added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Jan 8, 2016
@Sequoia

Sequoia commented Jan 8, 2016

Copy link
Copy Markdown
ContributorAuthor

Is the subsystem "docs" or "http"?

@Sequoia

Sequoia commented Jan 8, 2016

Copy link
Copy Markdown
ContributorAuthor

looks like "doc" from other commits, I'll go with that.

@Sequoia
doc: document server.listen return value
432aced
The server method returns `self` in order to
allow chaining.
closesnodejs#4571
@Sequoia
Sequoiaforce-pushed the document-server-listen-return-val branch from 1f36437 to 432acedCompareJanuary 8, 2016 18:48
@Sequoia

Sequoia commented Jan 8, 2016

Copy link
Copy Markdown
ContributorAuthor

OK lmk if it's still not in compliance! 😸

@SequoiaSequoia mentioned this pull request Jan 8, 2016
Closed
@silverwind

silverwind commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

do all the server methods return this for chaining?

They should, but there may be a few methods around that don't. If you find any that return undefined, we can likely change them.

@ryansobol

ryansobol commented Jan 9, 2016

Copy link
Copy Markdown
Contributor

LGTM

silverwind pushed a commit that referenced this pull request Jan 11, 2016
@Sequoia@silverwind
doc: document http's server.listen return value
9456f50
The server method returns `self` in order to allow chaining.
PR-URL: #4590Fixes: #4571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind

silverwind commented Jan 11, 2016

Copy link
Copy Markdown
Contributor

Thanks! Landed with slight tweaks to the message in 9456f50.

MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
@SequoiaMyles Borins
doc: document http's server.listen return value
749aaa7
The server method returns `self` in order to allow chaining.
PR-URL: #4590Fixes: #4571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorinsMylesBorins mentioned this pull request Jan 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
@SequoiaMyles Borins
doc: document http's server.listen return value
b181e26
The server method returns `self` in order to allow chaining.
PR-URL: #4590Fixes: #4571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
@SequoiaMyles Borins
doc: document http's server.listen return value
80ad952
The server method returns `self` in order to allow chaining.
PR-URL: #4590Fixes: #4571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
@SequoiaMyles Borins
doc: document http's server.listen return value
bb3af99
The server method returns `self` in order to allow chaining.
PR-URL: #4590Fixes: #4571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 14, 2016
@SequoiaMyles Borins
doc: document http's server.listen return value
19f21ab
The server method returns `self` in order to allow chaining.
PR-URL: #4590Fixes: #4571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@SequoiaMyles Borins
doc: document http's server.listen return value
5b45a46
The server method returns `self` in order to allow chaining.
PR-URL: #4590Fixes: #4571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorinsMylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@SequoiaMichael Scovetta
doc: document http's server.listen return value
e42869f
The server method returns `self` in order to allow chaining.
PR-URL: nodejs#4590Fixes: nodejs#4571
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@npm-robotnpm-robot mentioned this pull request Mar 31, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document return value of http.server.listen

5 participants

@Sequoia@jasnell@silverwind@ryansobol@MylesBorins