Uh oh!
There was an error while loading. Please reload this page.
add info on how to submit docs patch - #4591
Conversation
jasnell
commented
Jan 8, 2016
LGTM (again, tho, the commit log would need to be updated to conform to the style guideline :-) ...) |
Sequoia
commented
Jan 8, 2016
oh dang. OK well I'll wait if they all LG then I'll amend & overwrite. |
jasnell
commented
Jan 8, 2016
No worries, it can also be fixed by whoever lands the PR. Just something to keep in mind for next time :-) Thank you for the contributions! |
a63c6ed to
1d3e865CompareSequoia
commented
Jan 8, 2016
updated commit message to bring into compliance. |
ryansobol
commented
Jan 8, 2016
Might be awesome if the contributing guide were mentioned. I know that for me I didn't know it existed before I submitted my first pull request. |
silverwind
commented
Feb 26, 2016
@Sequoia wanna update to just link to CONTRIBUTING.md? |
1d3e865 to
0fc8545CompareSequoia
commented
Feb 29, 2016
@silverwind updated. |
silverwind
commented
Feb 29, 2016
LGTM |
There was a problem hiding this comment.
the links here can actually be moved to the end of the document... in-line simply do [submit an issue][] and [the contributing guide][], then at the bottom of the documentation.markdown file, add:
[submit an issue]: https://github.com/nodejs/node/issues/new
[the contributing guide]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
doing so would ensure that the text itself will line wrap correctly and will be easier to read later if changes need to be made.
jasnell
commented
Mar 2, 2016
LGTM with a nit |
The docs mentioned that the docs source live in the node source, but did not link to same.
0fc8545 to
fa78ce6CompareSequoia
commented
Mar 3, 2016
@jasnell updated |
jasnell
commented
Mar 7, 2016
LGTM |
The docs mentioned that the docs source live in the node source, but did not link to same. PR-URL: #4591 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Mar 7, 2016
Landed in 1d9a2b2 |
The docs mentioned that the docs source live in the node source, but did not link to same. PR-URL: #4591 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
The docs mentioned that the docs source live in the node source, but did not link to same. PR-URL: #4591 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
The docs mentioned that the docs source live in the node source, but did not link to same. PR-URL: #4591 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
The docs mentioned that the docs source live in the node source, but did not link to same. PR-URL: #4591 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
"About this documentation" said docs were in the node source but didn't link to them or mention how to report an issue.