Skip to content

src: update src/crypto/* in preparation for quic - #45912

Closed
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:quic-preparation-crypto
Closed

src: update src/crypto/* in preparation for quic#45912
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:quic-preparation-crypto

Conversation

@jasnell

@jasnelljasnell commented Dec 19, 2022

Copy link
Copy Markdown
Member

In preparation for use by the QUIC implementation, updates some pieces of src/crypto. These changes have been separated out of the larger quic PR (#44325) to make incremental review easier / possible.

/cc @bnoordhuis ... I've addressed the comments you had in #44325 here.

@nodejs-github-bot

nodejs-github-bot commented Dec 19, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 19, 2022
@jasnelljasnell mentioned this pull request Dec 19, 2022
Closed
@jasnelljasnell changed the title src: add GetCurrentCipherName/Version to crypto_commonsrc: update src/crypto/* in preparation for quicDec 19, 2022
@jasnell
jasnellforce-pushed the quic-preparation-crypto branch from e4321c8 to 088c5f0CompareDecember 19, 2022 21:31
addaleax
addaleax reviewed Dec 19, 2022
View reviewed changes
Comment threadsrc/crypto/crypto_context.h Outdated
@jasnell
jasnellforce-pushed the quic-preparation-crypto branch from 37ec12f to 64778c5CompareDecember 20, 2022 00:15
mcollina
mcollina approved these changes Dec 20, 2022
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green CI

bnoordhuis
bnoordhuis approved these changes Dec 20, 2022
View reviewed changes

@bnoordhuisbnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test failures are probably because of an inverted logical check.

Comment threadsrc/crypto/crypto_context.cc Outdated
@jasnell
jasnellforce-pushed the quic-preparation-crypto branch from 64778c5 to 267a482CompareDecember 20, 2022 19:06
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 20, 2022
@nodejs-github-bot

nodejs-github-bot commented Dec 21, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48685/

@github-actionsgithub-actionsBot mentioned this pull request Dec 22, 2022
Open
14 tasks
@github-actionsgithub-actionsBot mentioned this pull request Dec 23, 2022
Open
13 tasks
@nodejs-github-bot

nodejs-github-bot commented Dec 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48719/

This was referenced Dec 24, 2022
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Dec 25, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48730/

This was referenced Dec 26, 2022
Open
Open
@ronag

ronag commented Jan 19, 2023

Copy link
Copy Markdown
Member

Is anything stopping us from landing this?

@jasnell

jasnell commented Jan 20, 2023

Copy link
Copy Markdown
MemberAuthor

Just time for me to get back to it. I'll rebase it tomorrow and do another CI run then will get it landed.

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49129/

tniessen
tniessen reviewed Jan 22, 2023
View reviewed changes
Comment threadsrc/crypto/crypto_context.h Outdated
@jasnell
src: add GetCurrentCipherName/Version to crypto_common
e33237b
In preparation for use by the QUIC implementation.
@jasnell
src: add KeyObjectHandle::HasInstance
8c4bdea
In preparation for use by the QUIC implementation.
@jasnell
src: add additional utilities to crypto::SecureContext
7b624da
In preparation for use by the QUIC implementation.
@jasnell
jasnellforce-pushed the quic-preparation-crypto branch from 267a482 to 7b624daCompareJanuary 22, 2023 22:30
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49144/

aduh95
aduh95 approved these changes Feb 3, 2023
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Feb 3, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7079158...d523bfe

nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2023
@jasnell@nodejs-github-bot
src: add GetCurrentCipherName/Version to crypto_common
a689c4d
In preparation for use by the QUIC implementation.
PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2023
@jasnell@nodejs-github-bot
src: add KeyObjectHandle::HasInstance
c33c447
In preparation for use by the QUIC implementation.
PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Feb 3, 2023
@jasnell@nodejs-github-bot
src: add additional utilities to crypto::SecureContext
d523bfe
In preparation for use by the QUIC implementation.
PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@jasnell@MylesBorins
src: add GetCurrentCipherName/Version to crypto_common
a8a2d0e
In preparation for use by the QUIC implementation.
PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@jasnell@MylesBorins
src: add KeyObjectHandle::HasInstance
efc59d0
In preparation for use by the QUIC implementation.
PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@jasnell@MylesBorins
src: add additional utilities to crypto::SecureContext
95065c3
In preparation for use by the QUIC implementation.
PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@jasnell@danielleadams
src: add GetCurrentCipherName/Version to crypto_common
a639e2a
In preparation for use by the QUIC implementation.
PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@jasnell@danielleadams
src: add KeyObjectHandle::HasInstance
92fdb24
In preparation for use by the QUIC implementation.
PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@jasnell@danielleadams
src: add additional utilities to crypto::SecureContext
3aef68d
In preparation for use by the QUIC implementation.
PR-URL: #45912
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessentniessentniessen left review comments
@mcollinamcollinamcollina approved these changes
@bnoordhuisbnoordhuisbnoordhuis approved these changes
@anonriganonriganonrig approved these changes
@ronagronagronag approved these changes
@JungMinuJungMinuJungMinu approved these changes
@aduh95aduh95aduh95 approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@addaleaxaddaleaxAwaiting requested review from addaleax

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@jasnell@nodejs-github-bot@aduh95@ronag@mcollina@bnoordhuis@addaleax@anonrig@tniessen@JungMinu@RafaelGSS