Uh oh!
There was an error while loading. Please reload this page.
[v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors - #46005
Closed
fossamagna wants to merge 3 commits into
Closed
Conversation
nodejs-github-bot
commented
Dec 29, 2022
Collaborator
Review requested:
|
MoLow
approved these changes
Dec 29, 2022
nodejs-github-bot
commented
Dec 30, 2022
Collaborator
This was referenced Dec 31, 2022
danielleadamsforce-pushed
the
v18.x-staging
branch
from
January 3, 2023 15:48
68cca1e to
2098d7aCompare20 tasks
danielleadamsforce-pushed
the
v18.x-staging
branch
from
January 4, 2023 17:10
2098d7a to
bac6b7dCompare22 tasks
juanarbol
commented
Jan 22, 2023
Member
Hey! Thanks for this patch. Would you mind rebasing this? |
According to https://html.spec.whatwg.org/#environment-settings-object, the timeOrigin is a per-environment value. Worker's timeOrigin is the time when the worker is created. PR-URL: nodejs#43781 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
To distinguish per-context values from the node::Environment, split those values to a new node::Realm structure and consolidate bootstrapping methods with it. PR-URL: nodejs#44179 Refs: nodejs#42528 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: nodejs#44612 PR-URL: nodejs#45264 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
fossamagnaforce-pushed
the
backport-v18-test-runner-extraneous-async-fail
branch
from
January 23, 2023 01:30
6bba8f9 to
024450aComparefossamagna
commented
Jan 24, 2023
ContributorAuthor
@juanarbol Thanks. I rebased and pushed this PR. |
MoLow
commented
Jan 26, 2023
Member
the rebase did not seem to be successful, so I am closing in favor of #46360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This RP is backport of #45264 to v18.x.
Refs: #45264 (comment)