Uh oh!
There was an error while loading. Please reload this page.
test: fix http-upgrade-client flakiness - #4602
Closed
santigimeno wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Might wrap this callback in common.mustCall()
It's not guaranteed that the socket data is received in the same chunk as the upgrade response. Listen for the `data` event to make sure all the data is received.
santigimenoforce-pushed
the
test-http-upgrade-client
branch
from
January 11, 2016 20:33
ca6a9be to
b78b4cbComparesantigimeno
commented
Jan 11, 2016
MemberAuthor
PR updated with the proposed change applied |
mscdex
commented
Jan 11, 2016
Contributor
Trott
commented
Jan 11, 2016
Member
CI is green. LGTM. |
mscdex
commented
Jan 12, 2016
Contributor
LGTM |
1 similar comment
jasnell
commented
Jan 12, 2016
Member
LGTM |
jasnell pushed a commit
that referenced
this pull request
Jan 12, 2016
It's not guaranteed that the socket data is received in the same chunk as the upgrade response. Listen for the `data` event to make sure all the data is received. PR-URL: #4602 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Jan 13, 2016
Member
jasnell
commented
Jan 13, 2016
Member
Yes, sorry, just forgot to close it :-) |
rvagg pushed a commit
that referenced
this pull request
Jan 14, 2016
It's not guaranteed that the socket data is received in the same chunk as the upgrade response. Listen for the `data` event to make sure all the data is received. PR-URL: #4602 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 28, 2016
It's not guaranteed that the socket data is received in the same chunk as the upgrade response. Listen for the `data` event to make sure all the data is received. PR-URL: #4602 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 11, 2016
It's not guaranteed that the socket data is received in the same chunk as the upgrade response. Listen for the `data` event to make sure all the data is received. PR-URL: #4602 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
It's not guaranteed that the socket data is received in the same chunk as the upgrade response. Listen for the `data` event to make sure all the data is received. PR-URL: nodejs#4602 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
It's not guaranteed that the socket data is received in the same chunk as the upgrade response. Listen for the `data` event to make sure all the data is received. PR-URL: nodejs#4602 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
It's not guaranteed that the socket data is received in the same chunk as the upgrade response. Listen for the `data` event to make sure all the data is received. PR-URL: nodejs#4602 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not guaranteed that the socket data is received in the same chunk
as the upgrade response. Listen for the
dataevent to make sure allthe data is received.