Skip to content

test: add failing test for #45992 - #46075

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
alecmev:rl
Jan 22, 2023
Merged

test: add failing test for #45992#46075
aduh95 merged 1 commit into
nodejs:mainfrom
alecmev:rl

Conversation

@alecmev

@alecmevalecmev commented Jan 3, 2023•
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Refs: #45992

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 3, 2023
@alecmevalecmev mentioned this pull request Jan 3, 2023
Closed
@alecmev

alecmev commented Jan 4, 2023

Copy link
Copy Markdown
ContributorAuthor

Force-pushed to fix a linting issue.

@alecmev

alecmev commented Jan 21, 2023

Copy link
Copy Markdown
ContributorAuthor

@anonrig@aduh95 Can you trigger the workflows again, please?

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49123/

@aduh95
aduh95 merged commit de6c0e6 into nodejs:mainJan 22, 2023
@aduh95

aduh95 commented Jan 22, 2023

Copy link
Copy Markdown
Contributor

Landed in de6c0e6

@alecmev
alecmev deleted the rl branch January 22, 2023 11:59
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@alecmev@ruyadorno
test: add failing test for readline with carriage return
940484b
PR-URL: #46075
Refs: #45992
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@alecmev@juanarbol
test: add failing test for readline with carriage return
c8ca4e0
PR-URL: #46075
Refs: #45992
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarboljuanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@alecmev@juanarbol
test: add failing test for readline with carriage return
837ddcb
PR-URL: #46075
Refs: #45992
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@anonriganonriganonrig approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alecmev@nodejs-github-bot@aduh95@jasnell@anonrig