Uh oh!
There was an error while loading. Please reload this page.
docs: Adds usage of readline line-by-line parsing - #4609
Closed
eljefedelrodeodeljefe wants to merge 2 commits into
Closed
docs: Adds usage of readline line-by-line parsing#4609eljefedelrodeodeljefe wants to merge 2 commits into
eljefedelrodeodeljefe wants to merge 2 commits into
Conversation
mscdex
commented
Jan 10, 2016
Contributor
I think it may be better to include the new example after the one at the top of the document. |
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: #4609 Reviewed-By:
eljefedelrodeodeljefe
commented
Jan 10, 2016
ContributorAuthor
Okay, thanks. Did this in 89b2254. I force pushed the commit, but apparently it didn't update in the PR. Won't do this again... |
eljefedelrodeodeljefe
commented
Jan 11, 2016
ContributorAuthor
@silverwind I agree. Wasn't sure there. Did this in 228dd24. Thanks. |
silverwind
commented
Jan 11, 2016
Contributor
LGTM |
ryansobol
commented
Jan 11, 2016
Contributor
LGTM, although you might want to squash the commits down to just one. |
silverwind
commented
Jan 11, 2016
Contributor
Squashing is not an issue, we do that when landing. I acutally prefer them unsquashed so one can track changes that happens during the PRs lifetime. |
eljefedelrodeodeljefe
commented
Jan 11, 2016
ContributorAuthor
Okay. Looking at the process, I'd prefer it unsquashed also, in general. However you want it... |
ryansobol
commented
Jan 11, 2016
Contributor
Makes sense. :) |
jasnell
commented
Jan 11, 2016
Member
LGTM |
silverwind pushed a commit
that referenced
this pull request
Jan 11, 2016
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: #4609 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>>
silverwind
commented
Jan 11, 2016
Contributor
Thanks! Landed in 5a53cba. |
eljefedelrodeodeljefe
commented
Jan 11, 2016
ContributorAuthor
Cool. Thanks @silverwind . Will delete the branch then. |
MylesBorins pushed a commit
that referenced
this pull request
Jan 11, 2016
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: #4609 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jan 12, 2016
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: #4609 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>>
MylesBorins pushed a commit
that referenced
this pull request
Jan 13, 2016
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: #4609 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>>
MylesBorins pushed a commit
that referenced
this pull request
Jan 14, 2016
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: #4609 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>>
MylesBorins pushed a commit
that referenced
this pull request
Jan 14, 2016
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: #4609 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>>
rvagg
commented
Jan 18, 2016
Member
I think this is your first commit to core @eljefedelrodeodeljefe, welcome on board! It looks like you're already getting comfortable in the docs, we appreciate it and hope you're able to grok the processes and preferences around here, let us know if you need help on that front. |
MylesBorins pushed a commit
that referenced
this pull request
Jan 19, 2016
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: #4609 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>>
Merged
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
In order to make developers aware of node-core built-in functionality, which might replace module APIs, we should add an example of readline`s interface usage. SEO will eventually aid this goal, since it is well searched on Q&A sites. PR-URL: nodejs#4609 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>>
matthiasg
commented
Jun 6, 2018
It would have been great had this new documentation also included information on how to process each line asynchronously |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make developers aware of node-core built-in
functionality, which might replace module APIs, we should
add an example of readline`s interface usage.
SEO will eventually aid this goal, since it is well searched
on Q&A sites.
PR-URL: #4609
Reviewed-By: