Uh oh!
There was an error while loading. Please reload this page.
deps: add /deps/**/.github/ to .gitignore - #46091
Merged
nodejs-github-bot merged 1 commit intoJan 11, 2023
Merged
Conversation
nodejs-github-bot
commented
Jan 4, 2023
Collaborator
Review requested:
|
cjihrig
approved these changes
Jan 4, 2023
lpincaforce-pushed
the
ignore/github-directories-in-deps
branch
from
January 4, 2023 15:36
98dff80 to
42bcf19Compareruyadorno
approved these changes
Jan 4, 2023
Member
There was a problem hiding this comment.
No, it won't. The V8 sync script bypasses our .gitignore.
- Ignore `.github` directories in the `deps` directory. - Remove `deps/base64/base64/.github/`.
lpincaforce-pushed
the
ignore/github-directories-in-deps
branch
from
January 10, 2023 18:04
42bcf19 to
049ccb7Comparenodejs-github-bot
commented
Jan 10, 2023
Collaborator
nodejs-github-bot
commented
Jan 10, 2023
Collaborator
nodejs-github-bot
commented
Jan 10, 2023
Collaborator
targos
approved these changes
Jan 11, 2023
nodejs-github-bot
commented
Jan 11, 2023
Collaborator
Landed in 20359cc |
RafaelGSS pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
- Ignore `.github` directories in the `deps` directory. - Remove `deps/base64/base64/.github/`. PR-URL: nodejs#46091 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Jan 20, 2023
- Ignore `.github` directories in the `deps` directory. - Remove `deps/base64/base64/.github/`. PR-URL: #46091 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
juanarbol pushed a commit
that referenced
this pull request
Jan 26, 2023
- Ignore `.github` directories in the `deps` directory. - Remove `deps/base64/base64/.github/`. PR-URL: #46091 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
juanarbol pushed a commit
that referenced
this pull request
Jan 31, 2023
- Ignore `.github` directories in the `deps` directory. - Remove `deps/base64/base64/.github/`. PR-URL: #46091 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.githubdirectories in thedepsdirectory.deps/base64/base64/.github/.