Uh oh!
There was an error while loading. Please reload this page.
test: require common module only once - #4611
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests.
mscdex
commented
Jan 10, 2016
Contributor
LGTM |
Trott
commented
Jan 10, 2016
MemberAuthor
cjihrig
commented
Jan 10, 2016
Contributor
LGTM |
2 similar comments
jbergstroem
commented
Jan 10, 2016
Member
LGTM |
jasnell
commented
Jan 11, 2016
Member
LGTM |
jasnell pushed a commit
that referenced
this pull request
Jan 11, 2016
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: #4611 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Jan 11, 2016
Member
Landed in bfc4823 |
MylesBorins pushed a commit
that referenced
this pull request
Jan 11, 2016
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: #4611 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jan 12, 2016
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: #4611 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 28, 2016
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: #4611 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 11, 2016
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: #4611 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: nodejs#4611 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: nodejs#4611 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Two tests were requiring the common module twice. This removes the duplicate require statement in the tests. PR-URL: nodejs#4611 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.