inspector: allow opening inspector when NODE_V8_COVERAGE is set

[MoLow]

Fixes: #46110

[MoLow]

CC @nodejs/inspector

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/48881/

[bnoordhuis]

I kind of feel this is more a hack or workaround than a proper fix, possibly with undesirable side effects.

isEnabled() returns true because the inspector agent thread is running. Code coverage creates its own inspector session which in turn starts the agent thread.

Maybe the io_ != nullptr check here is wrong, that's the "is the agent thread already running?" check:

node/src/inspector_agent.cc

Lines 942 to 946 in 513c151

	boolAgent::IsActive() {
	if (client_ == nullptr)
	returnfalse;
	return io_ != nullptr || client_->IsActive();
	}

Or maybe it's sometimes needed - but in this case it gives the wrong behavior.

[cola119]

CMIIW, code coverage creates its own inspector session but doesn't start the agent thread while inspector.open() starts the agent thread. That means isEnabled() should return true when the agent thread is running, the condition when the inspector io (Agent::io_) exists. I've confirmed all tests are green.

diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc
index 3595536c78..1602faf1bd 100644
--- a/src/inspector_js_api.cc+++ b/src/inspector_js_api.cc@@ -273,7 +273,7 @@ static void RegisterAsyncHookWrapper(const FunctionCallbackInfo<Value>& args) {
void IsEnabled(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
- args.GetReturnValue().Set(InspectorEnabled(env));+ args.GetReturnValue().Set(env->inspector_agent()->IsListening());
}
void Open(const FunctionCallbackInfo<Value>& args) {

[MoLow]

thanks @cola119! I have pushed your suggestion

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/49236/

[nodejs-github-bot]

Landed in 7b4cc58