Uh oh!
There was an error while loading. Please reload this page.
stream: remove useless if test in transform - #4617
Closed
zoubin wants to merge 1 commit into
Closed
Conversation
silverwind
commented
Jan 11, 2016
Contributor
LGTM |
2 similar comments
cjihrig
commented
Jan 11, 2016
Contributor
LGTM |
mscdex
commented
Jan 11, 2016
Contributor
LGTM |
silverwind pushed a commit
that referenced
this pull request
Jan 11, 2016
PR-URL: #4617 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
silverwind
commented
Jan 11, 2016
Contributor
Thanks! Landed in ce9c93c. |
MylesBorins pushed a commit
that referenced
this pull request
Jan 11, 2016
PR-URL: #4617 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jan 12, 2016
PR-URL: #4617 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
rvagg
commented
Jan 18, 2016
Member
Thanks for fix @zoubin, I believe this is your first commit to core, if so, welcome on board! I hope you stick around and can other places to contribute. |
zoubin
commented
Jan 18, 2016
ContributorAuthor
@rvagg Glad to make contributions. I'll be watching this repo from now on. |
MylesBorins pushed a commit
that referenced
this pull request
Jan 28, 2016
PR-URL: #4617 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit
that referenced
this pull request
Feb 11, 2016
PR-URL: #4617 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
PR-URL: nodejs#4617 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
PR-URL: nodejs#4617 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4617 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Falsy
cbhas already been rejected in https://github.com/nodejs/node/blob/master/lib/_stream_transform.js#L69