Skip to content

deps: upgrade npm to 9.3.0 - #46193

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
npm:npm-v9.3.0
Jan 17, 2023
Merged

deps: upgrade npm to 9.3.0#46193
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
npm:npm-v9.3.0

Conversation

@npm-cli-bot

Copy link
Copy Markdown
Contributor

9.3.0 (2023-01-12)

Features

Bug Fixes

Documentation

Dependencies

@nodejs-github-botnodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jan 12, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@targos

Copy link
Copy Markdown
Member

@ljharb does npm/cli@cf175fb resolve your issue?

@ljharb

Copy link
Copy Markdown
Member

@targos no - that allows me to do npm --otp, which is a good bug fix, but if i do npm publish with no other config, i expect to be prompted for an OTP. npm 9 instead sends me to a web browser to do webauthn. My issue is that that "auth-type" change is breaking, on all extant node release lines.

@gengjiawengengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 15, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/46193
✔ Done loading data for nodejs/node/pull/46193
----------------------------------- PR info ------------------------------------
Title deps: upgrade npm to 9.3.0 (#46193)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch npm-cli-bot:npm-v9.3.0 -> nodejs:main
Labels npm, fast-track, needs-ci, dont-land-on-v14.x
Commits 1
- deps: upgrade npm to 9.3.0
Committers 1
- npm CLI robot PR-URL: https://github.com/nodejs/node/pull/46193
Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Jiawen Geng ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46193
Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Jiawen Geng --------------------------------------------------------------------------------
ℹ This PR was created on Thu, 12 Jan 2023 20:43:26 GMT
✔ Approvals: 3
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46193#pullrequestreview-1247358228
✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/46193#pullrequestreview-1247515683
✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/46193#pullrequestreview-1249214145
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
✖ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3923489114

@targostargos added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 15, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorinsMylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2023
@MylesBorins

Copy link
Copy Markdown
Contributor

I pushed a change to ignore a file with known conflict markers in the npm test suite

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@TrottTrott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 17, 2023
@Trott

Copy link
Copy Markdown
Member

@MylesBorins I added the label to squash the commits but if you want the commits to land separately, rebase to put your commit first.

@MylesBorinsMylesBorins added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 17, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 66b1356 into nodejs:mainJan 17, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 66b1356

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
PR-URL: nodejs#46193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 18, 2023
PR-URL: #46193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #46193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@juanarboljuanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
PR-URL: #46193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@wraithgar
wraithgar deleted the npm-v9.3.0 branch June 26, 2025 15:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@npm-cli-bot@targos@ljharb@nodejs-github-bot@MylesBorins@Trott@lpinca@cjihrig@tniessen@gengjiawen