Uh oh!
There was an error while loading. Please reload this page.
deps: backport 066747e from upstream V8 - #4625
Closed
ofrobots wants to merge 1 commit into
Closed
Conversation
ofrobots
commented
Jan 11, 2016
ContributorAuthor
cjihrig
commented
Jan 11, 2016
Contributor
LGTM |
ofrobots
commented
Jan 11, 2016
ContributorAuthor
Windows builds on the CI seem to be having issues. Relaunched the windows subset of the CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/880/ |
ofrobots
commented
Jan 12, 2016
ContributorAuthor
/cc @nodejs/v8 |
targos
commented
Jan 12, 2016
Member
LGTM once the |
indutny
commented
Jan 12, 2016
Member
orig files, otherwise LGTM |
This backport fixes a performance pathology in how arrays grow/shrink. Fixes: nodejs#3538 V8-Commit: v8/v8@066747e Original commit message: Make sure that NormalizeElements and ShouldConvertToFastElements are … …based on the same values BUG=v8:4518 LOG=n Review URL: https://codereview.chromium.org/1472293002 Cr-Commit-Position: refs/heads/master@{nodejs#32265}
ofrobots added a commit
that referenced
this pull request
Jan 12, 2016
This backport fixes a performance pathology in how arrays grow/shrink. Fixes: #3538 V8-Commit: v8/v8@066747e PR-URL: #4625 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Original commit message: Make sure that NormalizeElements and ShouldConvertToFastElements are … …based on the same values BUG=v8:4518 LOG=n Review URL: https://codereview.chromium.org/1472293002 Cr-Commit-Position: refs/heads/master@{#32265}
ofrobots
commented
Jan 12, 2016
ContributorAuthor
Landed on |
Merged
jasnell
commented
Jan 12, 2016
Member
@ofrobots ... can I ask you to open a PR for this against v4.x-staging? |
ofrobots added a commit
to ofrobots/node
that referenced
this pull request
Jan 13, 2016
This backport fixes a performance pathology in how arrays grow/shrink. Fixes: nodejs#3538 V8-Commit: v8/v8@066747e PR-URL: nodejs#4625 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Original commit message: Make sure that NormalizeElements and ShouldConvertToFastElements are … …based on the same values BUG=v8:4518 LOG=n Review URL: https://codereview.chromium.org/1472293002 Cr-Commit-Position: refs/heads/master@{nodejs#32265}
jasnell pushed a commit
that referenced
this pull request
Jan 13, 2016
This backport fixes a performance pathology in how arrays grow/shrink. Fixes: #3538 V8-Commit: v8/v8@066747e PR-URL: #4625 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Original commit message: Make sure that NormalizeElements and ShouldConvertToFastElements are … …based on the same values BUG=v8:4518 LOG=n Review URL: https://codereview.chromium.org/1472293002 Cr-Commit-Position: refs/heads/master@{#32265} Commit metadata for v4.x-staging: PR-URL: #4655 Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
commented
Jan 15, 2016
Member
labelled as |
MylesBorins pushed a commit
that referenced
this pull request
Jan 19, 2016
This backport fixes a performance pathology in how arrays grow/shrink. Fixes: #3538 V8-Commit: v8/v8@066747e PR-URL: #4625 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Original commit message: Make sure that NormalizeElements and ShouldConvertToFastElements are … …based on the same values BUG=v8:4518 LOG=n Review URL: https://codereview.chromium.org/1472293002 Cr-Commit-Position: refs/heads/master@{#32265} Commit metadata for v4.x-staging: PR-URL: #4655 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backport fixes a performance pathology in how arrays grow/shrink. This was a regression introduced in V8 4.5. The V8 team has already backported this a far back as V8 4.7. We need to float the backport for
v5.x(V8 4.6) andv4.x(V8 4.5).Fixes: #3538
V8-Commit: v8/v8@066747e
Original commit message:
Make sure that NormalizeElements and ShouldConvertToFastElements are …
…based on the same values
BUG=v8:4518
LOG=n
Review URL: https://codereview.chromium.org/1472293002
Cr-Commit-Position: refs/heads/master@{#32265}