Uh oh!
There was an error while loading. Please reload this page.
src: use explicit C++17 fallthrough - #46251
Merged
Merged
Conversation
This passes the strictest -Wimplicit-fallthrough setting.
nodejs-github-bot
commented
Jan 18, 2023
Collaborator
Review requested:
|
richardlau
approved these changes
Jan 18, 2023
anonrig
approved these changes
Jan 18, 2023
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Jan 18, 2023
nodejs-github-bot
commented
Jan 18, 2023
Collaborator
lpinca
approved these changes
Jan 18, 2023
addaleax
approved these changes
Jan 18, 2023
bnoordhuis
approved these changes
Jan 18, 2023
14 tasks
gengjiawen
approved these changes
Jan 19, 2023
jasnell
approved these changes
Jan 19, 2023
13 tasks
nodejs-github-bot
commented
Jan 20, 2023
Collaborator
Landed in c47ad58 |
This was referenced Jan 21, 2023
ruyadorno pushed a commit
that referenced
this pull request
Feb 1, 2023
This passes the strictest -Wimplicit-fallthrough setting. PR-URL: #46251 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol pushed a commit
that referenced
this pull request
Mar 3, 2023
This passes the strictest -Wimplicit-fallthrough setting. PR-URL: #46251 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
juanarbol pushed a commit
that referenced
this pull request
Mar 5, 2023
This passes the strictest -Wimplicit-fallthrough setting. PR-URL: #46251 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This passes the strictest
-Wimplicit-fallthroughsetting.