Skip to content

src: replace custom ASCII validation with simdutf one - #46271

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:simdutf-containsnonascii
Jan 21, 2023
Merged

src: replace custom ASCII validation with simdutf one#46271
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:simdutf-containsnonascii

Conversation

@addaleax

@addaleaxaddaleax commented Jan 19, 2023

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 19, 2023
tniessen
tniessen approved these changes Jan 19, 2023
View reviewed changes

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have (naively) assumed that many compilers would vectorize contains_non_ascii_slow.

Comment threadsrc/string_bytes.cc Outdated
@addaleax

addaleax commented Jan 19, 2023

Copy link
Copy Markdown
MemberAuthor

@tniessen Me too! Fwiw, I’m not really trying to optimize anything here (who even uses 'ascii'…) but rather just get rid of code we don’t need anymore.

@richardlau

richardlau commented Jan 19, 2023

Copy link
Copy Markdown
Member

The commit title is missing the "d" from "simdutf".

@addaleaxaddaleax changed the title src: replace custom ASCII validation with simutf onesrc: replace custom ASCII validation with simdutf oneJan 19, 2023
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2023
@addaleax
addaleaxforce-pushed the simdutf-containsnonascii branch from 5e740f8 to 8df6b9dCompareJanuary 19, 2023 16:13
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49082/

lpinca
lpinca approved these changes Jan 19, 2023
View reviewed changes
Comment threadsrc/string_bytes.cc

case ASCII:
if (contains_non_ascii(buf, buflen)) {
if (simdutf::validate_ascii_with_errors(buf, buflen).error) {

@lpincalpincaJan 19, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for using the error version? Is the common case to have invalid ASCII?

@addaleaxaddaleaxJan 19, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The with_errors variant bails out early if it detects invalid ASCII, instead of running the entire string, so my thought was that it would match the performance profile of the previous code here best.

The common case is to not use this branch (ASCII) at all :)

@nodejs-github-bot

nodejs-github-bot commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49088/

@nodejs-github-bot

nodejs-github-bot commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49091/

@nodejs-github-bot

nodejs-github-bot commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49092/

@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 19, 2023
@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2023
@github-actionsgithub-actionsBot mentioned this pull request Jan 20, 2023
Open
13 tasks
bnoordhuis
bnoordhuis approved these changes Jan 20, 2023
View reviewed changes
Comment threadsrc/string_bytes.cc
}

return false;
}

@bnoordhuisbnoordhuisJan 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete aside: I have a distinct memory of writing this code, it looks like how I would write such code, yet git blame attributes it to Isaac S... huh. The human mind is a fickle thing.

@addaleaxaddaleaxJan 20, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnoordhuis I double-checked out of interest (and also because it looks like code from you), and … you did! e325ace is all yours 🙂

@bnoordhuisbnoordhuisJan 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel vindicated now! Thanks for digging that up, Anna. :)

@anonriganonrigJan 20, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Written almost ten years ago, and you still remember your code. I've nothing but respect for all of you.

@github-actionsgithub-actionsBot mentioned this pull request Jan 21, 2023
Open
14 tasks
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6913140 into nodejs:mainJan 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6913140

This was referenced Jan 22, 2023
Open
Open
@addaleax
addaleax deleted the simdutf-containsnonascii branch January 23, 2023 10:14
This was referenced Jan 24, 2023
Open
Open
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@addaleax@ruyadorno
src: replace custom ASCII validation with simdutf one
35bf93b
PR-URL: #46271
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@ruyadornoruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@addaleax@juanarbol
src: replace custom ASCII validation with simdutf one
b7bdf1d
PR-URL: #46271
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@juanarboljuanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@addaleax@juanarbol
src: replace custom ASCII validation with simdutf one
18c4dd0
PR-URL: #46271
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This was referenced Dec 19, 2025
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@anonriganonriganonrig approved these changes
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@richardlaurichardlaurichardlau approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@addaleax@richardlau@nodejs-github-bot@bnoordhuis@jasnell@lpinca@anonrig@cjihrig@tniessen@RaisinTen