Uh oh!
There was an error while loading. Please reload this page.
src: remove unreachable UNREACHABLE - #46281
Merged
nodejs-github-bot merged 1 commit intoJan 22, 2023
Merged
Conversation
All paths leading up to this UNREACHABLE either return or abort. (If they did not, the compiler would at least emit a warning.)
jasnell
approved these changes
Jan 20, 2023
lpinca
approved these changes
Jan 20, 2023
nodejs-github-bot
commented
Jan 20, 2023
Collaborator
RaisinTen
approved these changes
Jan 20, 2023
nodejs-github-bot
commented
Jan 22, 2023
Collaborator
Landed in 8c308ab |
ruyadorno pushed a commit
that referenced
this pull request
Feb 1, 2023
All paths leading up to this UNREACHABLE either return or abort. (If they did not, the compiler would at least emit a warning.) PR-URL: #46281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
juanarbol pushed a commit
that referenced
this pull request
Mar 3, 2023
All paths leading up to this UNREACHABLE either return or abort. (If they did not, the compiler would at least emit a warning.) PR-URL: #46281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
juanarbol pushed a commit
that referenced
this pull request
Mar 5, 2023
All paths leading up to this UNREACHABLE either return or abort. (If they did not, the compiler would at least emit a warning.) PR-URL: #46281 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All paths leading up to this last
UNREACHABLEeither return or abort. (If they did not, the compiler would at least emit a warning.)