Skip to content

readline: fix detection of carriage return - #46306

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:readline-carriage-return
Jan 24, 2023
Merged

readline: fix detection of carriage return#46306
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:readline-carriage-return

Conversation

@aduh95

@aduh95aduh95 commented Jan 22, 2023

Copy link
Copy Markdown
Contributor

Fixes: #45992

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Jan 22, 2023
@aduh95aduh95 mentioned this pull request Jan 22, 2023
Closed
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49131/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit e8d4015 into nodejs:mainJan 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in e8d4015

@alecmev

alecmev commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

Thank you!

@aduh95
aduh95 deleted the readline-carriage-return branch January 24, 2023 14:11
ruyadorno pushed a commit that referenced this pull request Feb 1, 2023
@aduh95@ruyadorno
readline: fix detection of carriage return
4ae2492
Fixes: #45992
PR-URL: #46306
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@ruyadornoruyadorno mentioned this pull request Feb 1, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 3, 2023
@aduh95@juanarbol
readline: fix detection of carriage return
80ff382
Fixes: #45992
PR-URL: #46306
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@juanarboljuanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@aduh95@juanarbol
readline: fix detection of carriage return
2f7319e
Fixes: #45992
PR-URL: #46306
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@aymen94aymen94aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.readlineIssues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

readline sometimes produces lines with \r in them

9 participants

@aduh95@nodejs-github-bot@alecmev@jasnell@lpinca@anonrig@cjihrig@BridgeAR@aymen94