Uh oh!
There was an error while loading. Please reload this page.
debugger: remove variable redeclarations - #4633
Closed
Trott wants to merge 2 commits into
Closed
Conversation
cjihrig
commented
Jan 12, 2016
Contributor
I didn't look at the entire file. Would any of these changes work as |
Trott
commented
Jan 12, 2016
MemberAuthor
I dismissed |
cjihrig
commented
Jan 12, 2016
Contributor
We're using |
jasnell
commented
Jan 12, 2016
Member
LGTM if CI and @cjihrig are happy :-) |
Trott
commented
Jan 13, 2016
MemberAuthor
OK, definitely an option for a |
jasnell
commented
Jan 13, 2016
Member
Still LGTM |
cjihrig
commented
Jan 13, 2016
Contributor
LGTM too. |
Trott
commented
Jan 16, 2016
MemberAuthor
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jan 16, 2016
Some variables are declared with var more than once in the same scope. This change reduces the declarations to one per scope. PR-URL: nodejs#4633 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott
commented
Jan 16, 2016
MemberAuthor
Landed in 66b9c0d |
evanlucas pushed a commit
that referenced
this pull request
Jan 18, 2016
Some variables are declared with var more than once in the same scope. This change reduces the declarations to one per scope. PR-URL: #4633 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 28, 2016
Some variables are declared with var more than once in the same scope. This change reduces the declarations to one per scope. PR-URL: #4633 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 11, 2016
Some variables are declared with var more than once in the same scope. This change reduces the declarations to one per scope. PR-URL: #4633 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
Some variables are declared with var more than once in the same scope. This change reduces the declarations to one per scope. PR-URL: nodejs#4633 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
Some variables are declared with var more than once in the same scope. This change reduces the declarations to one per scope. PR-URL: nodejs#4633 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Some variables are declared with var more than once in the same scope. This change reduces the declarations to one per scope. PR-URL: nodejs#4633 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some variables are declared with
varmore than once in the same scope. This change reduces the declarations to one per scope.