Skip to content

[v18.x backport] src: use CreateEnvironment instead of inlining its code where possible - #46330

Closed
addaleax wants to merge 1 commit into
nodejs:v18.x-stagingfrom
addaleax:backport-45886-v18.x
Closed

[v18.x backport] src: use CreateEnvironment instead of inlining its code where possible#46330
addaleax wants to merge 1 commit into
nodejs:v18.x-stagingfrom
addaleax:backport-45886-v18.x

Conversation

@addaleax

@addaleaxaddaleax commented Jan 24, 2023

Copy link
Copy Markdown
Member

Only difference between the original PR and this is ExitCode::kBootstrapFailure vs. BOOTSTRAP_ERROR.

We had a number of places in which we created an Environment instance by performing each step in CreateEnvironment manually. Instead, just call the function itself.

PR-URL: #45886
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

@nodejs-github-bot

nodejs-github-bot commented Jan 24, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@addaleaxaddaleax mentioned this pull request Jan 24, 2023
Merged
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. v18.x labels Jan 24, 2023
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2023
@addaleaxaddaleax changed the title [v18.x backkport] src: use CreateEnvironment instead of inlining its code where possible[v18.x backport] src: use CreateEnvironment instead of inlining its code where possibleJan 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49149/

@github-actionsgithub-actionsBot mentioned this pull request Jan 25, 2023
Open
12 tasks
@nodejs-github-bot

nodejs-github-bot commented Jan 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49222/

@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49254/

@addaleax

addaleax commented Jan 30, 2023

Copy link
Copy Markdown
MemberAuthor

@juanarbol Are the CI failures here specific to this PR? There’s a lot of fs.watch failures so I assume they’re related to test changes having been backported but not code changes (specifically, 17ae2ab)?

@addaleax
addaleaxforce-pushed the backport-45886-v18.x branch from 335f8dc to 466d7e2CompareFebruary 9, 2023 17:42
@addaleax

addaleax commented Feb 9, 2023

Copy link
Copy Markdown
MemberAuthor

(did a clean rebase to be able to try CI again)

@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2023
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 9, 2023
@github-actions

github-actionsBot commented Feb 9, 2023

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✖ Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/4136947306

@MylesBorinsMylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49715/

juanarbol
juanarbol approved these changes Feb 24, 2023
View reviewed changes

@juanarboljuanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanarboljuanarbol added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2023
@addaleax@juanarbol
src: use CreateEnvironment instead of inlining its code where possible
481bbb4
We had a number of places in which we created an `Environment` instance
by performing each step in `CreateEnvironment` manually. Instead,
just call the function itself.
PR-URL: nodejs#45886
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49961/

@juanarbol

juanarbol commented Feb 24, 2023

Copy link
Copy Markdown
Member

Dropped 0f29b57 to make ncu land clean

This was referenced Feb 25, 2023
Open
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50044/

This was referenced Feb 28, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50134/

@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50137/

@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50138/

juanarbol pushed a commit that referenced this pull request Mar 1, 2023
@addaleax@juanarbol
src: use CreateEnvironment instead of inlining its code where possible
7f0b553
We had a number of places in which we created an `Environment` instance
by performing each step in `CreateEnvironment` manually. Instead,
just call the function itself.
PR-URL: #45886
Backport-PR-URL: #46330
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@juanarbol

juanarbol commented Mar 1, 2023

Copy link
Copy Markdown
Member

Landed in 7f0b553

This was referenced Mar 2, 2023
Open
Open
Open
Open
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@addaleax@juanarbol
src: use CreateEnvironment instead of inlining its code where possible
8adaa13
We had a number of places in which we created an `Environment` instance
by performing each step in `CreateEnvironment` manually. Instead,
just call the function itself.
PR-URL: #45886
Backport-PR-URL: #46330
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Mar 6, 2023
Open
20 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.processIssues and PRs related to the process subsystem.request-ci-failedAn error occurred while starting CI via request-ci label, and manual interventon is needed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@addaleax@nodejs-github-bot@juanarbol@MylesBorins