Uh oh!
There was an error while loading. Please reload this page.
doc: add documentation for socket.destroySoon() - #46337
Merged
nodejs-github-bot merged 1 commit intoJan 28, 2023
Merged
Conversation
nodejs-github-bot
commented
Jan 24, 2023
Collaborator
Review requested:
|
nodejs-github-bot
commented
Jan 28, 2023
Collaborator
Landed in 47cd966 |
ruyadorno pushed a commit
that referenced
this pull request
Feb 1, 2023
PR-URL: #46337 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Merged
juanarbol pushed a commit
that referenced
this pull request
Mar 3, 2023
PR-URL: #46337 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
juanarbol pushed a commit
that referenced
this pull request
Mar 5, 2023
PR-URL: #46337 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike other "private" methods like
socket._reset(),socket._getpeername(), etc.,socket.destroySoon()was not prefixed so I think it makes sense to document it.