Skip to content

[18.x backport] http: res setheaders - #46365

Closed
marco-ippolito wants to merge 2 commits into
nodejs:v18.x-stagingfrom
marco-ippolito:backport/18.x-setheaders
Closed

[18.x backport] http: res setheaders#46365
marco-ippolito wants to merge 2 commits into
nodejs:v18.x-stagingfrom
marco-ippolito:backport/18.x-setheaders

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Jan 26, 2023

Copy link
Copy Markdown
Member

PR-URL: #46109
As requested by @juanarbol#46109 (comment)

@nodejs-github-bot

nodejs-github-bot commented Jan 26, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. v18.x labels Jan 26, 2023
@richardlaurichardlau mentioned this pull request Jan 26, 2023
Closed
@nodejs-github-bot

nodejs-github-bot commented Jan 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49221/

@ShogunPandaShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49244/

@marco-ippolito
http: res.setHeaders first implementation
bcef834
PR-URL: nodejs#46109
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@marco-ippolito
http: res.setHeader 18.x backport
e835966
@nodejs-github-bot

nodejs-github-bot commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49960/

@juanarbol

This comment was marked as off-topic.

Sign in to view
This was referenced Feb 25, 2023
Open
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50046/

@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50050/

@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50060/

@marco-ippolitomarco-ippolito removed the needs-ci PRs that need a full CI run. label Feb 27, 2023
This was referenced Feb 28, 2023
Open
Open
juanarbol
juanarbol approved these changes Mar 1, 2023
View reviewed changes

@juanarboljuanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juanarbol pushed a commit to juanarbol/node that referenced this pull request Mar 1, 2023
@marco-ippolito@juanarbol
http: res.setHeaders first implementation
ba71900
PR-URL: nodejs#46109
Backport-PR-URL: nodejs#46365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@juanarbol

juanarbol commented Mar 1, 2023

Copy link
Copy Markdown
Member

Landed in ba71900

@github-actionsgithub-actionsBot mentioned this pull request Mar 2, 2023
Open
15 tasks
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@marco-ippolito@juanarbol
http: res.setHeaders first implementation
5019b54
PR-URL: #46109
Backport-PR-URL: #46365
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marco-ippolito@nodejs-github-bot@juanarbol@ShogunPanda