Skip to content

test: add trailing commas in test/js-native-api - #46385

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:native-api-dangle
Feb 3, 2023
Merged

test: add trailing commas in test/js-native-api#46385
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:native-api-dangle

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jan 27, 2023
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jan 29, 2023
PR-URL: nodejs#46385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95

Copy link
Copy Markdown
ContributorAuthor

Landed in 7079158

@aduh95
aduh95 merged commit 7079158 into nodejs:mainFeb 3, 2023
@aduh95
aduh95 deleted the native-api-dangle branch February 3, 2023 16:13
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
PR-URL: #46385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.node-apiIssues and PRs related to the Node-API.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@jasnell@legendecas@nodejs-github-bot