Skip to content

http: use v8::Array::New() with a prebuilt vector - #46447

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
joyeecheung:http-array
Feb 8, 2023
Merged

http: use v8::Array::New() with a prebuilt vector#46447
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
joyeecheung:http-array

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Jan 31, 2023

Copy link
Copy Markdown
Member

Avoid using v8::Array::Set() which results in JS execution and is thus slow. Prebuild the vector in C++ land and build the JS array directly with that vector whereever possible.

@joyeecheung
http: use v8::Array::New() with a prebuilt vector
8cf5500
Avoid using v8::Array::Set() which results in JS execution and is
thus slow. Prebuild the vector in C++ land and build the
JS array directly with that vector whereever possible.
@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. needs-ci PRs that need a full CI run. labels Jan 31, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes Jan 31, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ronag
ronag reviewed Jan 31, 2023
View reviewed changes
Comment threadsrc/node_http_parser.cc
ronag
ronag reviewed Jan 31, 2023
View reviewed changes
Comment threadsrc/node_http_parser.cc
ronag
ronag reviewed Jan 31, 2023
View reviewed changes
Comment threadsrc/node_http_parser.cc
ronag
ronag reviewed Jan 31, 2023
View reviewed changes
Comment threadsrc/node_http_parser.cc
@nodejs-github-bot

nodejs-github-bot commented Feb 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49332/

Flarna
Flarna reviewed Feb 3, 2023
View reviewed changes
Comment threadsrc/node_http_parser.cc
ASSIGN_OR_RETURN_UNWRAP(&list, args.Holder());

uint32_t i = 0;
std::vector<Local<Value>> result;

@FlarnaFlarnaFeb 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using MaybeStackBuffer to avoid allocations if number of elements is not too high?

@joyeecheungjoyeecheungFeb 4, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think v8::Array -> std::vector would make sense (to avoid C++ -> JS invocation costs) but std::vector -> MaybeStackBuffer probably would not make much difference...(and personally I prefer STL unless the home-grown alternatives makes a significant difference)

@nodejs-github-bot

nodejs-github-bot commented Feb 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49375/

This was referenced Feb 5, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49449/

@github-actionsgithub-actionsBot mentioned this pull request Feb 7, 2023
Open
18 tasks
@joyeecheungjoyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 8, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 8, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a5ede9c into nodejs:mainFeb 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

Landed in a5ede9c

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@joyeecheung@MylesBorins
http: use v8::Array::New() with a prebuilt vector
d8c527f
Avoid using v8::Array::Set() which results in JS execution and is
thus slow. Prebuild the vector in C++ land and build the
JS array directly with that vector whereever possible.
PR-URL: #46447
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@joyeecheung@danielleadams
http: use v8::Array::New() with a prebuilt vector
3d0602c
Avoid using v8::Array::Set() which results in JS execution and is
thus slow. Prebuild the vector in C++ land and build the
JS array directly with that vector whereever possible.
PR-URL: #46447
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@ronagronagronag approved these changes
@FlarnaFlarnaFlarna approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.http_parserIssues and PRs related to the HTTP Parser dependency or the http_parser binding.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@joyeecheung@nodejs-github-bot@mcollina@jasnell@addaleax@ronag@Flarna@RaisinTen