Skip to content

benchmark: add trailing commas in benchmark/buffers - #46473

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:buffer-dangle
Feb 4, 2023
Merged

benchmark: add trailing commas in benchmark/buffers#46473
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:buffer-dangle

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. labels Feb 2, 2023
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 3, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 95434fb into nodejs:mainFeb 4, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 95434fb

@aduh95
aduh95 deleted the buffer-dangle branch February 4, 2023 18:24
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
PR-URL: #46473
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46473
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.bufferIssues and PRs related to the buffer subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@jasnell@anonrig@MoLow@RaisinTen