Skip to content

test: enable api-invalid-label.any.js in encoding WPTs - #46506

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:more-encoding-wpt
Feb 7, 2023
Merged

test: enable api-invalid-label.any.js in encoding WPTs#46506
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:more-encoding-wpt

Conversation

@panva

@panvapanva commented Feb 5, 2023

Copy link
Copy Markdown
Member

Enables api-invalid-label.any.js WPTs to run.

@panvapanva added test Issues and PRs related to the tests. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. labels Feb 5, 2023
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 5, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panvapanva changed the title test: enable single-byte-decoder.window.js in encoding WPTstest: enable api-invalid-label.any.js in encoding WPTsFeb 5, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@panvapanva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 5, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@panvapanva added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 5, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2023
@nodejs-github-bot

This comment was marked as outdated.

@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 7, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 4d36ebd into nodejs:mainFeb 7, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 4d36ebd

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
PR-URL: #46506
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46506
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@panva
panva deleted the more-encoding-wpt branch August 22, 2025 14:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.encodingIssues and PRs related to the TextEncoder and TextDecoder APIs.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@panva@nodejs-github-bot@jasnell@targos@cjihrig@tniessen