Uh oh!
There was an error while loading. Please reload this page.
stream: refactor to use validateAbortSignal - #46520
Merged
Merged
Conversation
lpinca
approved these changes
Feb 6, 2023
nodejs-github-bot
commented
Feb 6, 2023
Collaborator
jasnell
approved these changes
Feb 7, 2023
nodejs-github-bot
commented
Feb 8, 2023
Collaborator
Landed in da89ab8 |
MylesBorins pushed a commit
that referenced
this pull request
Feb 18, 2023
PR-URL: #46520 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
danielleadams pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46520 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All APIs currently accept any
AbortSignal-like objects, which is whatvalidateAbortSignalchecks for. Let's use this here for consistency.