Skip to content

lib: tighten AbortSignal.prototype.throwIfAborted implementation - #46521

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:throwIfAborted
Feb 8, 2023
Merged

lib: tighten AbortSignal.prototype.throwIfAborted implementation#46521
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:throwIfAborted

Conversation

@aduh95

@aduh95aduh95 commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

All other runtimes I've tested check their internal flag rather than the getter. Let's do that for consistency as well.

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 6, 2023
@aduh95aduh95 mentioned this pull request Feb 6, 2023
Merged
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 7, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49460/

@nodejs-github-bot

nodejs-github-bot commented Feb 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49467/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 7, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 8, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8844cc4 into nodejs:mainFeb 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8844cc4

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@aduh95@MylesBorins
lib: tighten AbortSignal.prototype.throwIfAborted implementation
35570e9
PR-URL: #46521
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95@danielleadams
lib: tighten AbortSignal.prototype.throwIfAborted implementation
2b80d19
PR-URL: #46521
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@jasnell@cjihrig