Skip to content

src: add fflush() to SnapshotData::ToFile() - #46531

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:fflush-in-snapshot
Feb 8, 2023
Merged

src: add fflush() to SnapshotData::ToFile()#46531
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:fflush-in-snapshot

Conversation

@addaleax

@addaleaxaddaleax commented Feb 6, 2023

Copy link
Copy Markdown
Member

@nodejs-github-bot

nodejs-github-bot commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@addaleaxaddaleax mentioned this pull request Feb 6, 2023
Merged
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 6, 2023
@addaleaxaddaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49456/

@addaleaxaddaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 7, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 8, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5092346 into nodejs:mainFeb 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 8, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5092346

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@addaleax@MylesBorins
src: add fflush() to SnapshotData::ToFile()
31fb2e2
Refs: #46491 (comment)
PR-URL: #46531
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@addaleax@danielleadams
src: add fflush() to SnapshotData::ToFile()
9567436
Refs: #46491 (comment)
PR-URL: #46531
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@addaleax@nodejs-github-bot@jasnell@lpinca@cjihrig@tniessen@joyeecheung