Skip to content

doc: maintaining nghttp2 - #46539

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
marco-ippolito:feat/maintaining-nghttp2
Feb 21, 2023
Merged

doc: maintaining nghttp2#46539
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
marco-ippolito:feat/maintaining-nghttp2

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Feb 7, 2023

Copy link
Copy Markdown
Member

@nodejs-github-bot

nodejs-github-bot commented Feb 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 7, 2023
RafaelGSS
RafaelGSS reviewed Feb 7, 2023
View reviewed changes
Comment threaddoc/contributing/maintaining-http.md
mhdawson
mhdawson approved these changes Feb 7, 2023
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpinca
lpinca approved these changes Feb 7, 2023
View reviewed changes
Comment threaddoc/contributing/maintaining-nghttp2.md Outdated
RafaelGSS
RafaelGSS reviewed Feb 12, 2023
View reviewed changes
Comment threaddoc/contributing/maintaining-http.md Outdated
@marco-ippolito@RafaelGSS
doc: fix link
e147cac
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos
targos reviewed Feb 14, 2023
View reviewed changes
Comment threaddoc/contributing/maintaining-nghttp2.md
@RafaelGSSRafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 21, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b73fe69 into nodejs:mainFeb 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in b73fe69

targos pushed a commit that referenced this pull request Mar 13, 2023
@marco-ippolito@targos
doc: maintaining nghttp2
7806cae
PR-URL: #46539
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@marco-ippolito@danielleadams
doc: maintaining nghttp2
a384dd4
PR-URL: #46539
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos left review comments
@ShogunPandaShogunPandaShogunPanda approved these changes
@lpincalpincalpinca approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marco-ippolito@nodejs-github-bot@ShogunPanda@lpinca@targos@mhdawson@RafaelGSS