src: per-realm binding data by legendecas · Pull Request #46556 · nodejs/node

legendecas · 2023-02-08T07:03:22Z

Binding data is inherited from BaseObject and created in a specific
realm. They need to be tracked on a per-realm basis so that they can
be released properly when a realm is disposed.

nodejs-github-bot · 2023-02-08T07:03:27Z

joyeecheung

RSLGTM

github-actions · 2023-02-08T11:26:33Z

Failed to start CI

- Validating Jenkins credentials
✖ Jenkins credentials invalid

https://github.com/nodejs/node/actions/runs/4123606552

joyeecheung · 2023-02-08T15:35:55Z

CI is under security embargo until at least 14 Feb.

legendecas · 2023-02-08T15:57:43Z

Yeah, let's wait for the security releases first.

mcollina

lgtm

nodejs-github-bot · 2023-02-16T23:57:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49595/

nodejs-github-bot · 2023-02-20T02:28:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49757/

legendecas · 2023-02-20T14:31:59Z

Rebased on the tip of the main branch.

nodejs-github-bot · 2023-02-20T14:40:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49786/

Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed.

mcollina

lgtm

nodejs-github-bot · 2023-02-21T17:58:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49845/

nodejs-github-bot · 2023-02-21T22:43:27Z

Landed in ca07aba

juanarbol · 2023-03-01T20:36:32Z

Could you please backport this into v18.x?

Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed. PR-URL: #46556 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed. PR-URL: nodejs#46556 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> # Conflicts: # src/dataqueue/queue.cc

Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed. PR-URL: #46556 Backport-PR-URL: #47174 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> # Conflicts: # src/dataqueue/queue.cc

Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed. PR-URL: nodejs#46556 Backport-PR-URL: nodejs#47174 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> # Conflicts: # src/dataqueue/queue.cc

legendecas added the realm Issues and PRs related to the ShadowRealm API and node::Realm label Feb 8, 2023

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 8, 2023

legendecas force-pushed the binding-data branch from cd2001d to 5b2c0f8Compare February 8, 2023 07:54

joyeecheung approved these changes Feb 8, 2023
View reviewed changes

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2023

github-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 8, 2023

cjihrig approved these changes Feb 9, 2023
View reviewed changes

mcollina approved these changes Feb 9, 2023
View reviewed changes

legendecas mentioned this pull request Feb 9, 2023
Node.js built-in module support in the vm context #46558
Open

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 12, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2023

legendecas removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Feb 17, 2023

github-actionsBot mentioned this pull request Feb 18, 2023
CI Reliability 2023-02-18 nodejs/reliability#499
Open
32 tasks

legendecas force-pushed the binding-data branch from 5b2c0f8 to 0468776Compare February 20, 2023 14:27

legendecas added request-ci Add this label to start a Jenkins CI on a PR. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 20, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023

github-actionsBot mentioned this pull request Feb 21, 2023
CI Reliability 2023-02-21 nodejs/reliability#502
Open
26 tasks

src: per-realm binding data
7aadcd0
Binding data is inherited from BaseObject and created in a specific realm. They need to be tracked on a per-realm basis so that they can be released properly when a realm is disposed.

legendecas force-pushed the binding-data branch from 0468776 to 7aadcd0Compare February 21, 2023 17:45

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023

mcollina approved these changes Feb 21, 2023
View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Feb 21, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2023

nodejs-github-bot merged commit ca07aba into nodejs:mainFeb 21, 2023

github-actionsBot mentioned this pull request Feb 22, 2023
CI Reliability 2023-02-22 nodejs/reliability#503
Open
34 tasks

legendecas deleted the binding-data branch February 22, 2023 03:51

This was referenced Feb 22, 2023
src: use an array for faster binding data lookup #46620
Closed
timers: use V8 fast API calls #46579
Merged

juanarbol added the backport-requested-v18.x label Mar 1, 2023

targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged

legendecas mentioned this pull request Mar 20, 2023
[v18.x] src: per-realm binding data #47174
Closed

legendecas added backport-open-v18.x and removed backport-requested-v18.x labels Mar 20, 2023

danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged

Uh oh!

Uh oh!

Conversation

legendecas commented Feb 8, 2023

Uh oh!

nodejs-github-bot commented Feb 8, 2023• edited by legendecas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Feb 8, 2023

Uh oh!

joyeecheung commented Feb 8, 2023

Uh oh!

legendecas commented Feb 8, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Feb 16, 2023

Uh oh!

nodejs-github-bot commented Feb 20, 2023

Uh oh!

legendecas commented Feb 20, 2023

Uh oh!

nodejs-github-bot commented Feb 20, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Feb 21, 2023

Uh oh!

nodejs-github-bot commented Feb 21, 2023

Uh oh!

juanarbol commented Mar 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nodejs-github-bot commented Feb 8, 2023•
edited by legendecas
Loading