Skip to content

deps: copy postject-api.h and LICENSE to the deps folder - #46582

Closed
RaisinTen wants to merge 2 commits into
nodejs:mainfrom
RaisinTen:deps/copy-postject-api-and-license-to-the-deps-folder
Closed

deps: copy postject-api.h and LICENSE to the deps folder#46582
RaisinTen wants to merge 2 commits into
nodejs:mainfrom
RaisinTen:deps/copy-postject-api-and-license-to-the-deps-folder

Conversation

@RaisinTen

@RaisinTenRaisinTen commented Feb 9, 2023

Copy link
Copy Markdown
Member

Since postject-api.h gets compiled into Node.js, it makes more sense to put it in the deps directory instead of test/fixtures.

Refs: #45038 (comment)
Signed-off-by: Darshan Sen raisinten@gmail.com

cc @mhdawson @nodejs/single-executable

@nodejs-github-bot

nodejs-github-bot commented Feb 9, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Feb 9, 2023
@RaisinTenRaisinTen mentioned this pull request Feb 9, 2023
Merged
@RaisinTen
deps: copy postject-api.h and LICENSE to the deps folder
2c626f5
Since `postject-api.h` gets compiled into Node.js, it makes more sense
to put it in the `deps` directory instead of `test/fixtures`.
Refs: nodejs#45038 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen
RaisinTenforce-pushed the deps/copy-postject-api-and-license-to-the-deps-folder branch from 54baca1 to 2c626f5CompareFebruary 9, 2023 06:37
@RaisinTen

RaisinTen commented Feb 9, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Although this has the needs-ciPRs that need a full CI run. label, I'd like to land this PR manually without waiting for a green Jenkins CI because nothing here is actually compiled or tested on the Jenkins CI yet.

@RaisinTenRaisinTen added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 9, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@RaisinTenRaisinTen removed the needs-ci PRs that need a full CI run. label Feb 9, 2023
ovflowd
ovflowd approved these changes Feb 9, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp approval :)

anonrig
anonrig reviewed Feb 9, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-postject.sh
Comment threaddoc/contributing/maintaining-postject.md
anonrig
anonrig reviewed Feb 9, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-postject.sh
@RaisinTen@anonrig
Update tools/dep_updaters/update-postject.sh
ef62e1f
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2023
mhdawson
mhdawson approved these changes Feb 9, 2023
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpinca
lpinca approved these changes Feb 9, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-postject.sh
@RaisinTenRaisinTen removed the fast-track PRs that do not need to wait for 48 hours to land. label Feb 10, 2023
RaisinTen added a commit that referenced this pull request Feb 11, 2023
@RaisinTen
deps: copy postject-api.h and LICENSE to the deps folder
a37c083
Since `postject-api.h` gets compiled into Node.js, it makes more sense
to put it in the `deps` directory instead of `test/fixtures`.
Refs: #45038 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #46582
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RaisinTen

RaisinTen commented Feb 11, 2023

Copy link
Copy Markdown
MemberAuthor

Landed in a37c083

@RaisinTen
RaisinTen deleted the deps/copy-postject-api-and-license-to-the-deps-folder branch February 11, 2023 05:08
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@RaisinTen@MylesBorins
deps: copy postject-api.h and LICENSE to the deps folder
c0983cf
Since `postject-api.h` gets compiled into Node.js, it makes more sense
to put it in the `deps` directory instead of `test/fixtures`.
Refs: #45038 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #46582
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 19, 2023
Merged
@RaisinTenRaisinTen mentioned this pull request Apr 10, 2023
Closed
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@RaisinTen@danielleadams
deps: copy postject-api.h and LICENSE to the deps folder
65b877d
Since `postject-api.h` gets compiled into Node.js, it makes more sense
to put it in the `deps` directory instead of `test/fixtures`.
Refs: #45038 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #46582
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
@RaisinTenRaisinTen added the single-executable Issues and PRs related to single-executable applications label May 5, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@ovflowdovflowdovflowd approved these changes
+2 more reviewers
@mhdawsonmhdawsonmhdawson approved these changes
@tony-gotony-gotony-go approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dependenciesPull requests that update a dependency file.metaIssues and PRs related to the general management of the project.single-executableIssues and PRs related to single-executable applicationstoolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@RaisinTen@nodejs-github-bot@lpinca@anonrig@mhdawson@ovflowd@tony-go