Skip to content

node-api: add __wasm32__ guards on async works - #46633

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:node-api/wasm
Feb 24, 2023
Merged

node-api: add __wasm32__ guards on async works#46633
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:node-api/wasm

Conversation

@legendecas

@legendecaslegendecas commented Feb 13, 2023

Copy link
Copy Markdown
Member

Threaded work napi_async_work is not available on wasm. Hide their declaration if __wasm32__ is defined.

Refs: #33597
Refs: nodejs/node-addon-api#1283

@legendecaslegendecas added the node-api Issues and PRs related to the Node-API. label Feb 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 13, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 13, 2023
mhdawson
mhdawson approved these changes Feb 13, 2023
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49760/

@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49771/

@github-actionsgithub-actionsBot mentioned this pull request Feb 21, 2023
Open
26 tasks
@nodejs-github-bot

nodejs-github-bot commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49838/

This was referenced Feb 22, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49942/

@github-actionsgithub-actionsBot mentioned this pull request Feb 24, 2023
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49964/

@legendecaslegendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ff91fc1 into nodejs:mainFeb 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in ff91fc1

@legendecas
legendecas deleted the node-api/wasm branch February 24, 2023 06:12
This was referenced Feb 25, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@legendecas@targos
node-api: add __wasm32__ guards on async works
58b1f33
PR-URL: #46633
Refs: #33597
Refs: nodejs/node-addon-api#1283
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@legendecas@danielleadams
node-api: add __wasm32__ guards on async works
331073a
PR-URL: #46633
Refs: #33597
Refs: nodejs/node-addon-api#1283
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@legendecas@nodejs-github-bot@jasnell@cjihrig@tniessen@mhdawson