Uh oh!
There was an error while loading. Please reload this page.
benchmark: fix worker startup benchmark - #46680
Merged
Merged
Conversation
It previously called spawnProcess in spawnWorker, which was incorrect.
nodejs-github-bot
commented
Feb 16, 2023
Collaborator
Review requested:
|
cjihrig
approved these changes
Feb 16, 2023
legendecas
approved these changes
Feb 16, 2023
lpinca
approved these changes
Feb 16, 2023
jasnell
approved these changes
Feb 20, 2023
nodejs-github-bot
commented
Feb 22, 2023
Collaborator
nodejs-github-bot
commented
Feb 23, 2023
Collaborator
Landed in 9e06ef0 |
targos pushed a commit
that referenced
this pull request
Mar 13, 2023
It previously called spawnProcess in spawnWorker, which was incorrect. PR-URL: #46680 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Apr 11, 2023
It previously called spawnProcess in spawnWorker, which was incorrect. PR-URL: #46680 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It previously called spawnProcess in spawnWorker, which was incorrect.