Skip to content

node-api: verify cleanup hooks order - #46692

Closed
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:node-api/cleanup-order
Closed

node-api: verify cleanup hooks order#46692
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:node-api/cleanup-order

Conversation

@legendecas

@legendecaslegendecas commented Feb 17, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Cleanup hooks are called before the environment shutdown finalizer
invocations.

/cc @nodejs/node-api

@legendecaslegendecas added test Issues and PRs related to the tests. node-api Issues and PRs related to the Node-API. labels Feb 17, 2023
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 17, 2023
@legendecaslegendecas mentioned this pull request Feb 17, 2023
Merged
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49759/

@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49785/

This was referenced Feb 21, 2023
Open
Open
mhdawson
mhdawson approved these changes Feb 23, 2023
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

nodejs-github-bot commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49943/

@KevinEadyKevinEady mentioned this pull request Feb 24, 2023
Closed
@nodejs-github-bot

nodejs-github-bot commented Mar 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50171/

@github-actionsgithub-actionsBot mentioned this pull request Mar 3, 2023
Open
18 tasks
@legendecas

legendecas commented Mar 3, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

It seems like the test is only failing on the alpine build. I'll take a look at it.

This was referenced Mar 4, 2023
Open
Open
Open
Open
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2023
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 9, 2023
@github-actions

github-actionsBot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Starting PR CI job
✘ Failed to start PR CI: 403 Forbidden
https://github.com/nodejs/node/actions/runs/4376492148

@legendecas
node-api: verify cleanup hooks order
2f01895
Cleanup hooks are called before the environment shutdown finalizer
invocations.
@legendecas
legendecasforce-pushed the node-api/cleanup-order branch from 3dd11d2 to 2f01895CompareMarch 9, 2023 16:19
@aduh95aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Mar 9, 2023
@github-actionsgithub-actionsBot mentioned this pull request Mar 10, 2023
Open
22 tasks
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023
This was referenced Mar 11, 2023
Open
Open
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 12, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50339/

@github-actionsgithub-actionsBot mentioned this pull request Mar 13, 2023
Open
20 tasks
@nodejs-github-bot

nodejs-github-bot commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50342/

@nodejs-github-bot

nodejs-github-bot commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50344/

@nodejs-github-bot

nodejs-github-bot commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50348/

@github-actionsgithub-actionsBot mentioned this pull request Mar 14, 2023
Open
24 tasks
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50372/

@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50379/

legendecas added a commit that referenced this pull request Mar 14, 2023
@legendecas
node-api: verify cleanup hooks order
b80ab31
Cleanup hooks are called before the environment shutdown finalizer
invocations.
PR-URL: #46692
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@legendecas

legendecas commented Mar 14, 2023

Copy link
Copy Markdown
MemberAuthor

Landed in b80ab31

@legendecas
legendecas deleted the node-api/cleanup-order branch March 14, 2023 16:58
This was referenced Mar 15, 2023
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Mar 18, 2023
@legendecas@targos
node-api: verify cleanup hooks order
b3fe2ba
Cleanup hooks are called before the environment shutdown finalizer
invocations.
PR-URL: #46692
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@github-actionsgithub-actionsBot mentioned this pull request Mar 19, 2023
Open
19 tasks
This was referenced Apr 3, 2023
Merged
Merged
@toyobayashitoyobayashi mentioned this pull request Apr 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@legendecas@danielleadams
node-api: verify cleanup hooks order
d8d2d33
Cleanup hooks are called before the environment shutdown finalizer
invocations.
PR-URL: #46692
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.node-apiIssues and PRs related to the Node-API.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@legendecas@nodejs-github-bot@jasnell@cjihrig@mhdawson@aduh95