Skip to content

tools: run format-cpp on node-api test c files - #46694

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:node-api/format-cpp
Feb 24, 2023
Merged

tools: run format-cpp on node-api test c files#46694
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:node-api/format-cpp

Conversation

@legendecas

@legendecaslegendecas commented Feb 17, 2023

Copy link
Copy Markdown
Member

Run format-cpp on node-api test c files but exclude them from cpplint target list.

Cpplint complains about Use nullptr instead of NULL on these c source codes.

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Feb 17, 2023
joyeecheung
joyeecheung reviewed Feb 17, 2023
View reviewed changes
Comment threadMakefile Outdated
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49758/

@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49787/

This was referenced Feb 21, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49968/

@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49972/

@legendecaslegendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c6f23ee into nodejs:mainFeb 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in c6f23ee

@legendecas
legendecas deleted the node-api/format-cpp branch February 28, 2023 06:05
targos pushed a commit that referenced this pull request Mar 13, 2023
@legendecas@targos
tools: run format-cpp on node-api test c files
f6bd145
PR-URL: #46694
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@legendecas@danielleadams
tools: run format-cpp on node-api test c files
4065e5c
PR-URL: #46694
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@anonriganonriganonrig approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@legendecas@nodejs-github-bot@jasnell@anonrig@cjihrig@joyeecheung@RaisinTen