Skip to content

tools: update wpt.fyi used daily checkout ref - #46730

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:wpt-daily-update-ref
Closed

tools: update wpt.fyi used daily checkout ref#46730
panva wants to merge 1 commit into
nodejs:mainfrom
panva:wpt-daily-update-ref

Conversation

@panva

@panvapanva commented Feb 19, 2023

Copy link
Copy Markdown
Member

For some reason actions/checkout does not fetch the actual branch at a given time consistently. Let's try with the gh API.

$ echo "WPT_DAILY_REF=$(gh api /repos/web-platform-tests/wpt/branches/epochs/daily --jq '.commit.sha')"
WPT_DAILY_REF=96ef5777e50f7ed8f54b91525002d6708fc097d7

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 19, 2023
@panvapanva added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 19, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

Comment thread.github/workflows/daily-wpt-fyi.yml Outdated
@panva
panvaforce-pushed the wpt-daily-update-ref branch from 901f88d to 8325f02CompareFebruary 19, 2023 17:55
@panva

Copy link
Copy Markdown
MemberAuthor

🙏 fast-trackPRs that do not need to wait for 48 hours to land. above so that the jobs start with consistent wpt ref.

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@nodejs-github-bot

This comment was marked as resolved.

panva added a commit that referenced this pull request Feb 19, 2023
PR-URL: #46730
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva

Copy link
Copy Markdown
MemberAuthor

Landed in 225c578

@panvapanva closed this Feb 19, 2023
@panva
panva deleted the wpt-daily-update-ref branch February 19, 2023 18:59
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46730
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@panva@nodejs-github-bot@anonrig@aduh95@danielleadams