Skip to content

test: fix test-v8-collect-gc-profile-in-worker.js - #46735

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:fix_test-v8-collect-gc-profile-in-worker.js
Feb 24, 2023
Merged

test: fix test-v8-collect-gc-profile-in-worker.js#46735
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:fix_test-v8-collect-gc-profile-in-worker.js

Conversation

@theanarkh

@theanarkhtheanarkh commented Feb 19, 2023

Copy link
Copy Markdown
Contributor

fix test-v8-collect-gc-profile-in-worker.js.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 19, 2023
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49732/

@github-actionsgithub-actionsBot mentioned this pull request Feb 20, 2023
Open
24 tasks
@joyeecheungjoyeecheung mentioned this pull request Feb 20, 2023
Closed
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49809/

This was referenced Feb 21, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49902/

@github-actionsgithub-actionsBot mentioned this pull request Feb 23, 2023
Open
31 tasks
@theanarkhtheanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2023
@theanarkh

theanarkh commented Feb 23, 2023

Copy link
Copy Markdown
ContributorAuthor

Why node-test-commit-aix pending all the time 🤔.

@theanarkh
theanarkhforce-pushed the fix_test-v8-collect-gc-profile-in-worker.js branch from 528928a to d3d115dCompareFebruary 23, 2023 14:24
@theanarkhtheanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49938/

@github-actionsgithub-actionsBot mentioned this pull request Feb 24, 2023
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49967/

@theanarkhtheanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b3663e0 into nodejs:mainFeb 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in b3663e0

@github-actionsgithub-actionsBot mentioned this pull request Feb 25, 2023
Open
28 tasks
@github-actionsgithub-actionsBot mentioned this pull request Feb 26, 2023
Open
15 tasks
targos pushed a commit that referenced this pull request Mar 13, 2023
@theanarkh@targos
test: fix test-v8-collect-gc-profile-in-worker.js
9c7a2e3
PR-URL: #46735
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@theanarkh@danielleadams
test: fix test-v8-collect-gc-profile-in-worker.js
ea71a2a
PR-URL: #46735
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@theanarkh@nodejs-github-bot@jasnell@lpinca@cjihrig@tniessen