test: fix flaky test-watch-mode-files_watcher by MoLow · Pull Request #46738 · nodejs/node

MoLow · 2023-02-19T19:53:30Z

cjihrig

LGTM. Can you try running a stress test as well. Oh, and fiels -> files in the commit message.

MoLow · 2023-02-19T21:47:15Z

LGTM. Can you try running a stress test as well. Oh, and fiels -> files in the commit message.

The issue was reproduced pretty easily on my local machine so I made sure running 1000 times does not reproduce the issue

nodejs-github-bot · 2023-02-19T22:30:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49750/

debadree25

Tested, no longer reproduces on my machine too!

nodejs-github-bot · 2023-02-20T10:21:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49774/

github-actions · 2023-02-20T21:24:33Z

Fast-track has been requested by @anonrig. Please 👍 to approve.

richardlau · 2023-02-20T21:29:15Z

I'd prefer if the typo in the commit message that Colin previously pointed out was fixed.

nodejs-github-bot · 2023-02-20T21:33:13Z

Commit Queue failed

- Loading data for nodejs/node/pull/46738
✔ Done loading data for nodejs/node/pull/46738
----------------------------------- PR info ------------------------------------
Title test: fix flaky test-watch-mode-fiels_watcher (#46738)
Author Moshe Atlow (@MoLow)
Branch MoLow:fix-flaky-test-watch-mode-files-watcher -> nodejs:main
Labels test, flaky-test, fast-track, needs-ci
Commits 1
- test: fix flaky test-watch-mode-fiels_watcher
Committers 1
- Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/46738
Reviewed-By: Colin Ihrig Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46738
Reviewed-By: Colin Ihrig Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli --------------------------------------------------------------------------------
ℹ This PR was created on Sun, 19 Feb 2023 19:53:30 GMT
✔ Approvals: 3
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46738#pullrequestreview-1304880465
✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/46738#pullrequestreview-1305321785
✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46738#pullrequestreview-1306348044
ℹ This PR is being fast-tracked
✖ The fast-track request requires at least one collaborator's approval (👍).
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-02-20T10:21:32Z: https://ci.nodejs.org/job/node-test-pull-request/49774/
- Querying data for job/node-test-pull-request/49774/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4227200793

nodejs-github-bot · 2023-02-21T06:25:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49815/

nodejs-github-bot · 2023-02-21T08:32:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49819/

nodejs-github-bot · 2023-02-21T09:18:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49822/

nodejs-github-bot · 2023-02-21T10:14:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49826/

nodejs-github-bot · 2023-02-21T11:19:28Z

Commit Queue failed

- Loading data for nodejs/node/pull/46738
✔ Done loading data for nodejs/node/pull/46738
----------------------------------- PR info ------------------------------------
Title test: fix flaky test-watch-mode-files_watcher (#46738)
Author Moshe Atlow (@MoLow)
Branch MoLow:fix-flaky-test-watch-mode-files-watcher -> nodejs:main
Labels test, flaky-test, fast-track, needs-ci
Commits 1
- test: fix flaky test-watch-mode-files_watcher
Committers 1
- Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/46738
Reviewed-By: Colin Ihrig Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46738
Reviewed-By: Colin Ihrig Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - test: fix flaky test-watch-mode-files_watcher
ℹ This PR was created on Sun, 19 Feb 2023 19:53:30 GMT
✔ Approvals: 3
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46738#pullrequestreview-1304880465
✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/46738#pullrequestreview-1305321785
✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46738#pullrequestreview-1306348044
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-02-21T10:14:17Z: https://ci.nodejs.org/job/node-test-pull-request/49826/
- Querying data for job/node-test-pull-request/49826/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4232081092

PR-URL: #46738 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

MoLow · 2023-02-21T11:22:25Z

Landed in 254574e

PR-URL: #46738 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 19, 2023

MoLow added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Feb 19, 2023

cjihrig approved these changes Feb 19, 2023
View reviewed changes

MoLow requested a review from benjamingr February 19, 2023 21:58

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023

github-actionsBot mentioned this pull request Feb 20, 2023
CI Reliability 2023-02-20 nodejs/reliability#501
Open
24 tasks

debadree25 approved these changes Feb 20, 2023
View reviewed changes

This comment was marked as outdated.
Sign in to view

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 20, 2023

joyeecheung mentioned this pull request Feb 20, 2023
parallel/test-runner-reporters is flaking #46747
Closed

anonrig approved these changes Feb 20, 2023
View reviewed changes

anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 20, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 20, 2023

github-actionsBot mentioned this pull request Feb 21, 2023
CI Reliability 2023-02-21 nodejs/reliability#502
Open
26 tasks

test: fix flaky test-watch-mode-files_watcher
6853faa

MoLow force-pushed the fix-flaky-test-watch-mode-files-watcher branch from 28d21eb to 6853faaCompare February 21, 2023 06:09

MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 21, 2023

MoLow changed the title ~~test: fix flaky test-watch-mode-fiels_watcher~~test: fix flaky test-watch-mode-files_watcherFeb 21, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 21, 2023

MoLow added a commit that referenced this pull request Feb 21, 2023
test: fix flaky test-watch-mode-files_watcher
254574e
PR-URL: #46738 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

MoLow closed this Feb 21, 2023

MoLow deleted the fix-flaky-test-watch-mode-files-watcher branch February 21, 2023 11:22

This was referenced Feb 22, 2023
CI Reliability 2023-02-22 nodejs/reliability#503
Open
CI Reliability 2023-02-23 nodejs/reliability#504
Open

targos pushed a commit that referenced this pull request Mar 13, 2023
test: fix flaky test-watch-mode-files_watcher
d5784c7
PR-URL: #46738 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged

danielleadams pushed a commit that referenced this pull request Apr 11, 2023
test: fix flaky test-watch-mode-files_watcher
b894899
PR-URL: #46738 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged

Uh oh!

Uh oh!

Conversation

MoLow commented Feb 19, 2023

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

MoLow commented Feb 19, 2023

Uh oh!

nodejs-github-bot commented Feb 19, 2023

Uh oh!

debadree25 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Feb 20, 2023

Uh oh!

github-actionsBot commented Feb 20, 2023

Uh oh!

richardlau commented Feb 20, 2023

Uh oh!

nodejs-github-bot commented Feb 20, 2023

Uh oh!

nodejs-github-bot commented Feb 21, 2023

Uh oh!

nodejs-github-bot commented Feb 21, 2023

Uh oh!

nodejs-github-bot commented Feb 21, 2023

Uh oh!

nodejs-github-bot commented Feb 21, 2023

Uh oh!

nodejs-github-bot commented Feb 21, 2023

Uh oh!

MoLow commented Feb 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants