deps: fix libuv for android by nappy · Pull Request #46746 · nodejs/node

nappy · 2023-02-20T13:50:11Z

Fix android build errors introduced by the upgrade to libuv 1.44.2

Fixes: #46743
Fixes: #46744

nodejs-github-bot · 2023-02-20T13:50:15Z

Review requested:

@nodejs/gyp

lpinca

RSLGTM

bnoordhuis

Can probably be fast-tracked?

github-actions · 2023-02-20T20:04:49Z

Fast-track has been requested by @bnoordhuis. Please 👍 to approve.

nodejs-github-bot · 2023-02-20T23:19:27Z

Commit Queue failed

- Loading data for nodejs/node/pull/46746
✔ Done loading data for nodejs/node/pull/46746
----------------------------------- PR info ------------------------------------
Title deps: fix libuv for android (#46746)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch nappy:nappy-patch-1 -> nodejs:main
Labels libuv, fast-track, author ready, needs-ci
Commits 1
- deps: fix libuv for android
Committers 1
- GitHub PR-URL: https://github.com/nodejs/node/pull/46746
Fixes: https://github.com/nodejs/node/issues/46743
Fixes: https://github.com/nodejs/node/issues/46744
Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46746
Fixes: https://github.com/nodejs/node/issues/46743
Fixes: https://github.com/nodejs/node/issues/46744
Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen Reviewed-By: Yagiz Nizipli --------------------------------------------------------------------------------
ℹ This PR was created on Mon, 20 Feb 2023 13:50:11 GMT
✔ Approvals: 6
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306031079
✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306054082
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306069521
✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306278383
✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306349810
✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306419569
ℹ This PR is being fast-tracked
✔ Last GitHub CI successful
✖ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4227754655

nodejs-github-bot · 2023-02-21T06:30:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49816/

nappy · 2023-02-21T08:33:39Z

Profile updated

nodejs-github-bot · 2023-02-21T11:19:41Z

Commit Queue failed

- Loading data for nodejs/node/pull/46746
✔ Done loading data for nodejs/node/pull/46746
----------------------------------- PR info ------------------------------------
Title deps: fix libuv for android (#46746)
Author Julian Dropmann (@nappy, first-time contributor)
Branch nappy:nappy-patch-1 -> nodejs:main
Labels libuv, fast-track, author ready
Commits 1
- deps: fix libuv for android
Committers 1
- GitHub PR-URL: https://github.com/nodejs/node/pull/46746
Fixes: https://github.com/nodejs/node/issues/46743
Fixes: https://github.com/nodejs/node/issues/46744
Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen Reviewed-By: Yagiz Nizipli Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46746
Fixes: https://github.com/nodejs/node/issues/46743
Fixes: https://github.com/nodejs/node/issues/46744
Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: Anna Henningsen Reviewed-By: Yagiz Nizipli Reviewed-By: Darshan Sen --------------------------------------------------------------------------------
ℹ This PR was created on Mon, 20 Feb 2023 13:50:11 GMT
✔ Approvals: 7
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306031079
✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306054082
✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306069521
✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306278383
✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306349810
✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306419569
✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/46746#pullrequestreview-1306753762
ℹ This PR is being fast-tracked
✖ Last GitHub CI failed
ℹ Last Full PR CI on 2023-02-21T06:30:04Z: https://ci.nodejs.org/job/node-test-pull-request/49816/
- Querying data for job/node-test-pull-request/49816/
✔ Last Jenkins CI successful
⚠ PR author is a new contributor: @nappy(julian@dropmann.org)
⚠ - commit b738caed4282 is authored by 56575+nappy@users.noreply.github.com
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4232081092

bnoordhuis · 2023-02-21T11:32:44Z

@nappy you may want to update and force-push your commit so it has you as the author instead of users.noreply.github.com.

Fix android build errors introduced by the upgrade to libuv 1.44.2 Fixes: nodejs#46743Fixes: nodejs#46744

nodejs-github-bot · 2023-02-21T22:32:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49857/

nodejs-github-bot · 2023-02-22T02:19:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49862/

nodejs-github-bot · 2023-02-22T16:34:35Z

Landed in ee22706

Fix android build errors introduced by the upgrade to libuv 1.44.2 Fixes: #46743Fixes: #46744 PR-URL: #46746 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Feb 20, 2023

lpinca approved these changes Feb 20, 2023
View reviewed changes

richardlau approved these changes Feb 20, 2023
View reviewed changes

cjihrig approved these changes Feb 20, 2023
View reviewed changes

bnoordhuis approved these changes Feb 20, 2023
View reviewed changes

bnoordhuis added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 20, 2023

addaleax approved these changes Feb 20, 2023
View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2023

anonrig approved these changes Feb 20, 2023
View reviewed changes

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 20, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 20, 2023

anonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 21, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023

This comment was marked as outdated.
Sign in to view

RaisinTen approved these changes Feb 21, 2023
View reviewed changes

bnoordhuis added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Feb 21, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 21, 2023

This comment was marked as outdated.
Sign in to view

deps: fix libuv for android
a963899
Fix android build errors introduced by the upgrade to libuv 1.44.2 Fixes: nodejs#46743Fixes: nodejs#46744

nappy force-pushed the nappy-patch-1 branch from b738cae to a963899Compare February 21, 2023 14:11

richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 21, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023

This comment was marked as outdated.
Sign in to view

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2023

github-actionsBot mentioned this pull request Feb 22, 2023
CI Reliability 2023-02-22 nodejs/reliability#503
Open
34 tasks

richardlau approved these changes Feb 22, 2023
View reviewed changes

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 22, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 22, 2023

nodejs-github-bot merged commit ee22706 into nodejs:mainFeb 22, 2023

github-actionsBot mentioned this pull request Feb 23, 2023
CI Reliability 2023-02-23 nodejs/reliability#504
Open
31 tasks

targos mentioned this pull request Mar 14, 2023
v19.8.0 release proposal #47087
Merged

danielleadams mentioned this pull request Apr 11, 2023
v18.16.0 release proposal #47502
Merged

Uh oh!

Uh oh!

Conversation

nappy commented Feb 20, 2023

Uh oh!

nodejs-github-bot commented Feb 20, 2023

Uh oh!

lpinca left a comment

Choose a reason for hiding this comment

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Feb 20, 2023

Uh oh!

nodejs-github-bot commented Feb 20, 2023

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Feb 21, 2023

Uh oh!

nappy commented Feb 21, 2023

Uh oh!

nodejs-github-bot commented Feb 21, 2023

Uh oh!

bnoordhuis commented Feb 21, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Feb 21, 2023

Uh oh!

nodejs-github-bot commented Feb 22, 2023

Uh oh!

nodejs-github-bot commented Feb 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants