Skip to content

assert: fix exception message for assert(0) on try catch block - #46760

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
hidecology:fix/exception-msg-for-assert
Feb 26, 2023
Merged

assert: fix exception message for assert(0) on try catch block#46760
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
hidecology:fix/exception-msg-for-assert

Conversation

@hidecology

@hidecologyhidecology commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Fixes: #30872

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Feb 22, 2023
BridgeAR
BridgeAR approved these changes Feb 22, 2023
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

Comment threadlib/assert.js Outdated
function parseCode(code, offset) {
// Lazy load acorn.
if (parseExpressionAt === undefined) {
if (parseExpressionAt === undefined || tokenizer === undefined) {

@BridgeARBridgeARFeb 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(parseExpressionAt===undefined||tokenizer===undefined){
if(parseExpressionAt===undefined){

The second condition is not needed due to the tokenizer and parseExpressionAt being defined at the same moment.

@hidecologyhidecologyFeb 22, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BridgeAR
Thanks for your feedback.
I see. I will revert this conditional expression back to the previous one.

Comment threadlib/assert.js Outdated
// expression is bigger than the provided buffer.
// eslint-disable-next-line no-throw-literal
throw null;
if (node && node.node.end >= offset) {

@BridgeARBridgeARFeb 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(node&&node.node.end>=offset){
if(node?.node.end>=offset){

@hidecologyhidecologyFeb 22, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BridgeAR
Got it. I will change this code.

@BridgeARBridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49866/

aduh95
aduh95 reviewed Feb 22, 2023
View reviewed changes
Comment threadtest/parallel/test-assert.js
@cola119cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49963/

cola119
cola119 approved these changes Feb 24, 2023
View reviewed changes
Comment threadtest/parallel/test-assert.js
Comment threadtest/parallel/test-assert.js
Comment threadtest/parallel/test-assert.js
@cola119
cola119 requested a review from aduh95February 24, 2023 06:55
@BridgeARBridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 25, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49996/

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 26, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3c0131a into nodejs:mainFeb 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3c0131a

targos pushed a commit that referenced this pull request Mar 13, 2023
@hidecology@targos
assert: fix exception message for assert(0) on try catch block
eaca288
Fixes: #30872
PR-URL: #46760
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@hidecology@targos
assert: fix exception message for assert(0) on try catch block
e11f08e
Fixes: #30872
PR-URL: #46760
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@hidecology@danielleadams
assert: fix exception message for assert(0) on try catch block
c742493
Fixes: #30872
PR-URL: #46760
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeARBridgeARBridgeAR approved these changes
@cola119cola119cola119 approved these changes
@aduh95aduh95Awaiting requested review from aduh95

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exception message for assert(0) depends on whitespace

5 participants

@hidecology@nodejs-github-bot@BridgeAR@aduh95@cola119