Uh oh!
There was an error while loading. Please reload this page.
tools: add undici WPTs to daily WPT Report - #46763
Closed
panva wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
commented
Feb 22, 2023
Collaborator
Review requested:
|
panva
commented
Feb 22, 2023
MemberAuthor
cc @KhafraDev |
anonrig
approved these changes
Feb 22, 2023
panva
commented
Feb 22, 2023
MemberAuthor
Here's a merged run Coming from undici are the following three
Complete merged report https://staging.wpt.fyi/results/?run_id=5247378118410240&run_id=6086989598162944 |
panvaforce-pushed
the
wpt-report-undici
branch
from
February 25, 2023 19:23
c0072b2 to
2b8c774Comparepanvaforce-pushed
the
wpt-report-undici
branch
from
February 25, 2023 19:24
2b8c774 to
00b73b7Comparepanva
marked this pull request as ready for review
February 25, 2023 19:31
aduh95
reviewed
Feb 26, 2023
Uh oh!
There was an error while loading. Please reload this page.
panvaforce-pushed
the
wpt-report-undici
branch
from
February 26, 2023 19:22
00b73b7 to
7efbe0aCompareaduh95
approved these changes
Feb 26, 2023
aduh95
left a comment
Contributor
There was a problem hiding this comment.
I don't understand everything this PR is doing, but overall it LGTM.
panva
commented
Feb 27, 2023
MemberAuthor
cc @nodejs/actions |
panvaforce-pushed
the
wpt-report-undici
branch
from
February 27, 2023 09:26
7efbe0a to
3190142Compareanonrig
approved these changes
Feb 27, 2023
MemberAuthor
blocked waiting for undici's next release to be in nightly, otherwise ready for review |
nodejs-github-bot
commented
Mar 13, 2023
Collaborator
Landed in f6e4e12...f41d507 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46763 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46763 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46763 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46763 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the WPT daily report submitted to wpt.fyi with WPTs related to all globals imported from
nodejs/undici.This is done by querying the WPT version included in the nodejs checkout, locally checking out undici repo on that given version, installing its dependencies and executing
npm run test:wpt(whilst ignoring its exit code) with a present environment variable that instructs the undici WPTRunner to add results to an existing wpt report file.If an existing release doesn't have the Undici WPT Report capabilities it will create the report as it did until now, without undici globals WPTs.
It also adds a GITHUB_STEP_SUMMARY to the workflow.