Uh oh!
There was an error while loading. Please reload this page.
meta: update CODEOWNERS of url implementations - #46775
Merged
Merged
Conversation
nodejs-github-bot
commented
Feb 22, 2023
Collaborator
Review requested:
|
ronag
approved these changes
Feb 22, 2023
debadree25
approved these changes
Feb 22, 2023
lpinca
approved these changes
Feb 22, 2023
lemire
approved these changes
Feb 22, 2023
RaisinTen
approved these changes
Feb 23, 2023
nodejs-github-bot
commented
Feb 24, 2023
Collaborator
Landed in b6c56cb |
targos pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46775 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46775 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
commented
Apr 11, 2023
Contributor
I think this is blocked by #46410 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the codeowners document and adds @nodejs/url team to URL related files and dependencies