Skip to content

meta: remove unnecessary onboarding step - #46793

Merged
nodejs-github-bot merged 1 commit into
mainfrom
Trott-patch-1
Feb 25, 2023
Merged

meta: remove unnecessary onboarding step#46793
nodejs-github-bot merged 1 commit into
mainfrom
Trott-patch-1

Conversation

@Trott

Copy link
Copy Markdown
Member

While it is nice to notify the TSC about accepted nominations, it is not strictly necessary and I think we should streamline things as much as possible.

While it is nice to notify the TSC about accepted nominations,
it is not strictly necessary and I think we should streamline
things as much as possible.
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 23, 2023
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 23, 2023

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 70cdc5d into mainFeb 25, 2023
@nodejs-github-bot
nodejs-github-bot deleted the Trott-patch-1 branch February 25, 2023 15:28
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 70cdc5d

targos pushed a commit that referenced this pull request Mar 13, 2023
While it is nice to notify the TSC about accepted nominations,
it is not strictly necessary and I think we should streamline
things as much as possible.
PR-URL: #46793
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
While it is nice to notify the TSC about accepted nominations,
it is not strictly necessary and I think we should streamline
things as much as possible.
PR-URL: #46793
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

14 participants

@Trott@nodejs-github-bot@mcollina@cjihrig@ronag@tniessen@richardlau@BethGriggs@legendecas@mhdawson@aduh95@trivikr@RafaelGSS@RaisinTen