Skip to content

test: simplify test-tls-alert - #46805

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-tls-alert-refactor
Feb 25, 2023
Merged

test: simplify test-tls-alert#46805
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:test-tls-alert-refactor

Conversation

@tniessen

@tniessentniessen commented Feb 23, 2023

Copy link
Copy Markdown
Member

Avoid the process 'exit' event handler and use execFile instead of manual stream operations.

Refs: #46751

@tniessen
test: simplify test-tls-alert
965146b
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.
Refs: nodejs#46751
@tniessentniessen added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to the tests. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 23, 2023
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 23, 2023
@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49945/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 78b911d into nodejs:mainFeb 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 78b911d

targos pushed a commit that referenced this pull request Mar 13, 2023
@tniessen@targos
test: simplify test-tls-alert
4a810dc
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.
Refs: #46751
PR-URL: #46805
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@tniessen@targos
test: simplify test-tls-alert
f21ed3a
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.
Refs: #46751
PR-URL: #46805
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tniessen@danielleadams
test: simplify test-tls-alert
3644796
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.
Refs: #46751
PR-URL: #46805
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@aymen94aymen94aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@nodejs-github-bot@jasnell@lpinca@cjihrig@aymen94